Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

renderer: Don't panic for unknown NodeKind #107

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion renderer/renderer.go
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ package renderer

import (
"bufio"
"fmt"
"io"
"sync"

Expand Down Expand Up @@ -161,7 +162,14 @@ func (r *renderer) Render(w io.Writer, source []byte, n ast.Node) error {
err := ast.Walk(n, func(n ast.Node, entering bool) (ast.WalkStatus, error) {
s := ast.WalkStatus(ast.WalkContinue)
var err error
f := r.nodeRendererFuncs[n.Kind()]

k := n.Kind()
if int(k) >= len(r.nodeRendererFuncs) {
return s, fmt.Errorf("unrecognized node kind %v cannot be rendered: "+
"register a renderer for this node kind first", k)
}

f := r.nodeRendererFuncs[k]
if f != nil {
s, err = f(writer, source, n, entering)
}
Expand Down
25 changes: 25 additions & 0 deletions renderer/renderer_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
package renderer

import (
"io/ioutil"
"strings"
"testing"

"github.com/yuin/goldmark/parser"
"github.com/yuin/goldmark/text"
)

func TestRenderUnknownNode(t *testing.T) {
src := []byte("# Foo\n\nHello world")
node := parser.NewParser().Parse(text.NewReader(src))

r := NewRenderer()
err := r.Render(ioutil.Discard, src, node)
if err == nil {
t.Fatalf("Render() expected error")
}

if !strings.Contains(err.Error(), "unrecognized node kind Document") {
t.Errorf("Render() failed with unexpected error: %v", err)
}
}