Fix all cloning issues with pyod models #471
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Antoni Baum antoni.baum@protonmail.com
This PR fixes all issues with pyod model cloning by ensuring that scikit-learn API requirements are followed. No logic has been changed. The previously commented out cloning tests have been reenabled and are passing, as well as other tests for the models changed.
Being able to clone models is critical for https://github.com/pycaret/pycaret, which uses pyod's models for its Anomaly Detection module.
All Submissions Basics:
All Submissions Cores:
New Model Submissions: