Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix all cloning issues with pyod models #471

Merged
merged 1 commit into from
Mar 8, 2023

Conversation

Yard1
Copy link
Contributor

@Yard1 Yard1 commented Jan 8, 2023

Signed-off-by: Antoni Baum antoni.baum@protonmail.com

This PR fixes all issues with pyod model cloning by ensuring that scikit-learn API requirements are followed. No logic has been changed. The previously commented out cloning tests have been reenabled and are passing, as well as other tests for the models changed.

Being able to clone models is critical for https://github.com/pycaret/pycaret, which uses pyod's models for its Anomaly Detection module.

All Submissions Basics:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you checked all Issues to tie the PR to a specific one?

All Submissions Cores:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?
  • Does your submission pass tests, including CircleCI, Travis CI, and AppVeyor?
  • Does your submission have appropriate code coverage? The cutoff threshold is 95% by Coversall.

New Model Submissions:

  • Have you created a .py in ~/pyod/models/?
  • Have you created a _example.py in ~/examples/?
  • Have you created a test_.py in ~/pyod/test/?
  • Have you lint your code locally prior to submission?

Signed-off-by: Antoni Baum <antoni.baum@protonmail.com>
@yzhao062 yzhao062 merged commit 541e2e3 into yzhao062:development Mar 8, 2023
@yzhao062
Copy link
Owner

yzhao062 commented Mar 8, 2023

Sorry for being extremely late on this. It will be in the latest version today.

@Yard1 Yard1 deleted the fix_cloning branch March 8, 2023 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants