Fix the http-client performance problem #77
Conversation
| authService: AuthService, | ||
| metrics: RouteMetrics)( | ||
| implicit | ||
| val authService: AuthService, |
There was a problem hiding this comment.
Please do it in one line: implicit val
There was a problem hiding this comment.
can't do that :( that's how scalariform formats it... I tried to change the style, but it seems it's not possible... 👎
There was a problem hiding this comment.
It's a sign, even scalariform doesn't like implicits :)
There was a problem hiding this comment.
Oh, interesting... perhaps worth filing a bug at https://github.com/scala-ide/scalariform ?
There was a problem hiding this comment.
there is already a ticket scala-ide/scalariform#214
|
👍 |
|
Closes #70 |
Fix the http-client performance problem
| authUserToRoute(team) | ||
| } | ||
| case ServiceResult.Failure(Ex(ex)) => { | ||
| logger.error(s"OAuthService failed with exception $ex") |
There was a problem hiding this comment.
Just making sure that you've omitted including ex in the error call (i.e. error(ex, "") which includes the exception, not just message then)
|
Looks good 👍 // Hope you don't mind me coming in to comment here, was at @danpersa's request :) |
Tip: Don't block inside of actors 💯