-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: gtf sorting #121
fix: gtf sorting #121
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @mkatsanto, Thanks for the PR!
I ran the local-conda test successfully (exit code 0) and manually checking the results looked fine.
I only have minor comments on the pipeline documentation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fixes!
Description
The provided gtf annotation files provided by Ensembl can cause errors by ALFA.
To avoid this issue, we introduce an extra rule that sorts the gtf file by chromosome, start and end.
Fixes #113
Type of change
Please delete options that are not relevant.
Conventional Commits guidelines
https://www.conventionalcommits.org/en/v1.0.0/
Changes to workflow inputs (sample table and/or configs)
Changes to workflow outputs
Everything else: patch
(add any other conventional commit in the beginning of the PR title)
Checklist: