Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: gtf sorting #121

Merged
merged 7 commits into from
Mar 20, 2023
Merged

fix: gtf sorting #121

merged 7 commits into from
Mar 20, 2023

Conversation

mkatsanto
Copy link
Collaborator

Description

The provided gtf annotation files provided by Ensembl can cause errors by ALFA.
To avoid this issue, we introduce an extra rule that sorts the gtf file by chromosome, start and end.

Fixes #113

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Documentation updated

Conventional Commits guidelines

Changes to workflow inputs (sample table and/or configs)

  • major (add BREAKING CHANGE: in the beginning of the PR title)
    • more fields/properties are required
    • existing ones are dropped entirely
  • minor (add feat: in the beginning of the PR title)
    • optional fields/properties are added
    • required ones are made optional

Changes to workflow outputs

  • major (add BREAKING CHANGE: in the beginning of the PR title)
    • changes lead to removal/change of existing outputs (format or location)
  • minor (add feat: in the beginning of the PR title)
    • additional outputs are generated
    • content (but not format or location) of existing outputs changes

Everything else: patch
(add any other conventional commit in the beginning of the PR title)

Checklist:

  • My code changes follow the style of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • New and existing tests pass locally with my changes
  • I have updated the project's documentation

dominikburri
dominikburri previously approved these changes Mar 20, 2023
Copy link
Contributor

@dominikburri dominikburri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mkatsanto, Thanks for the PR!
I ran the local-conda test successfully (exit code 0) and manually checking the results looked fine.
I only have minor comments on the pipeline documentation.

pipeline_documentation.md Show resolved Hide resolved
pipeline_documentation.md Outdated Show resolved Hide resolved
Copy link
Contributor

@dominikburri dominikburri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes!

@mkatsanto mkatsanto merged commit 0cc8e86 into dev Mar 20, 2023
@mkatsanto mkatsanto deleted the gtf_sorting branch March 20, 2023 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sort gtf -issue with alfa
2 participants