Refactor constants to add constants::load
#106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it easier to load constants into the ECC chip.
Codecov Report
@@ Coverage Diff @@
## main #106 +/- ##
==========================================
- Coverage 82.40% 80.95% -1.46%
==========================================
Files 33 34 +1
Lines 2092 2111 +19
==========================================
- Hits 1724 1709 -15
- Misses 368 402 +34
Continue to review full report at Codecov.
|
This was referenced Jun 5, 2021
Closed
daira
reviewed
Jun 5, 2021
daira
reviewed
Jun 5, 2021
str4d
changed the title
constants to add constants::load.rsconstants to add constants::load
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
daira
reviewed
Jun 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it easier to load constants into the ECC chip.