Optimized ECC chip #73
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
therealyingtong
force-pushed
the
ecc-impl
branch
3 times, most recently
from
46066ae
to
cacf755
Compare
Codecov Report
@@ Coverage Diff @@
## utils-chip #73 +/- ##
==============================================
+ Coverage 82.36% 85.90% +3.54%
==============================================
Files 36 50 +14
Lines 2438 3781 +1343
==============================================
+ Hits 2008 3248 +1240
- Misses 430 533 +103
Continue to review full report at Codecov.
|
therealyingtong
force-pushed
the
ecc-impl
branch
from
cacf755
to
4c032a1
Compare
therealyingtong
force-pushed
the
ecc-impl
branch
2 times, most recently
from
4c6ff3a
to
b77f4b2
Compare
therealyingtong
force-pushed
the
ecc-gadget
branch
from
4baf3e1
to
4f2b4d2
Compare
therealyingtong
force-pushed
the
ecc-impl
branch
2 times, most recently
from
53803b0
to
6f605a7
Compare
therealyingtong
force-pushed
the
ecc-gadget
branch
from
911b528
to
db60fd2
Compare
ebfull
requested changes
May 21, 2021
therealyingtong
force-pushed
the
ecc-impl
branch
2 times, most recently
from
3f90a2a
to
eada6a9
Compare
daira
reviewed
May 22, 2021
daira
reviewed
May 22, 2021
The EccConfig only knows about 10 generic advice columns. These columns are renamed by individual components (e.g. AddConfig, MulConfig). The mapping for each individual config is captured in its impl From<EccConfig>.
…requires a doubling. Signed-off-by: Daira Hopwood <daira@jacaranda.org>
…on that requires a doubling. Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Inline equality assertions on values to individual components (flagged off with #[cfg(test)]. Move module-specific tests into respective modules.
…pes. We do not load the fixed bases into a single location in the circuit; rather, they are assigned to fixed columns at the offsets where they need to be used. The EccLoaded struct was not storing any references to circuit variables. It was holding constants in memory which the caller can instead directly access. Similarly, there is no need to have the FixedPoint or FixedPointShort associated types in the EccInstructions trait, since these types do not contain references to circuit variables. The corresponding get_fixed() and get_fixed_short() instructions are also removed.
This was defining shared behaviour between the mul_fixed::short and mul_fixed::full_width modules. But the behaviour can be captured by simply sharing the same mul_fixed::Config.
There is no need to enumerate FixedPointsShort or to make a newtype, since ValueCommitV is the only fixed base used with short signed scalars.
…vs. short scalars
Tests do not always use the MockProver.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #38.
Depends on Utils chip (#89).