-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimized ECC chip #73
Commits on Jun 4, 2021
-
Configuration menu - View commit details
-
Copy full SHA for c9331b1 - Browse repository at this point
Copy the full SHA c9331b1View commit details -
Configuration menu - View commit details
-
Copy full SHA for b752b92 - Browse repository at this point
Copy the full SHA b752b92View commit details -
Configuration menu - View commit details
-
Copy full SHA for 46af16b - Browse repository at this point
Copy the full SHA 46af16bView commit details -
Configuration menu - View commit details
-
Copy full SHA for ae288a2 - Browse repository at this point
Copy the full SHA ae288a2View commit details -
Configuration menu - View commit details
-
Copy full SHA for d6116d6 - Browse repository at this point
Copy the full SHA d6116d6View commit details -
Configuration menu - View commit details
-
Copy full SHA for b67d1f7 - Browse repository at this point
Copy the full SHA b67d1f7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 94d0cd3 - Browse repository at this point
Copy the full SHA 94d0cd3View commit details -
Configuration menu - View commit details
-
Copy full SHA for d8f02af - Browse repository at this point
Copy the full SHA d8f02afView commit details -
Configuration menu - View commit details
-
Copy full SHA for 13d9024 - Browse repository at this point
Copy the full SHA 13d9024View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5c4e307 - Browse repository at this point
Copy the full SHA 5c4e307View commit details -
Configuration menu - View commit details
-
Copy full SHA for 23bebc6 - Browse repository at this point
Copy the full SHA 23bebc6View commit details -
Configuration menu - View commit details
-
Copy full SHA for f751555 - Browse repository at this point
Copy the full SHA f751555View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7182130 - Browse repository at this point
Copy the full SHA 7182130View commit details -
Configuration menu - View commit details
-
Copy full SHA for 05eb13c - Browse repository at this point
Copy the full SHA 05eb13cView commit details -
Configuration menu - View commit details
-
Copy full SHA for b58a8f5 - Browse repository at this point
Copy the full SHA b58a8f5View commit details -
Configuration menu - View commit details
-
Copy full SHA for d9a95e9 - Browse repository at this point
Copy the full SHA d9a95e9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8f630d8 - Browse repository at this point
Copy the full SHA 8f630d8View commit details -
Configuration menu - View commit details
-
Copy full SHA for eb5d829 - Browse repository at this point
Copy the full SHA eb5d829View commit details -
Configuration menu - View commit details
-
Copy full SHA for 62f3b3f - Browse repository at this point
Copy the full SHA 62f3b3fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 71c3f99 - Browse repository at this point
Copy the full SHA 71c3f99View commit details -
Define separate configs for each operation
This removes the need to manually rename columns for each separate context. Instead, each operation's config now implements From<EccConfig>, providing a derivation from the top-level configuration.
Configuration menu - View commit details
-
Copy full SHA for 4909a93 - Browse repository at this point
Copy the full SHA 4909a93View commit details -
Use complete addition for last addition in fixed-base scalar mul
This allows fixed-base scalar mul to return (0,0) for [0]B.
Configuration menu - View commit details
-
Copy full SHA for a236f63 - Browse repository at this point
Copy the full SHA a236f63View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6102e45 - Browse repository at this point
Copy the full SHA 6102e45View commit details -
Configuration menu - View commit details
-
Copy full SHA for 70d6a56 - Browse repository at this point
Copy the full SHA 70d6a56View commit details -
Fix bugs in complete addition formulae.
Add tests to check that points related by the cubic endomorphism are not constrained to add up to (0,0).
Configuration menu - View commit details
-
Copy full SHA for 46ac3f2 - Browse repository at this point
Copy the full SHA 46ac3f2View commit details -
Configuration menu - View commit details
-
Copy full SHA for f911b70 - Browse repository at this point
Copy the full SHA f911b70View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9a46d1f - Browse repository at this point
Copy the full SHA 9a46d1fView commit details -
Configuration menu - View commit details
-
Copy full SHA for a399085 - Browse repository at this point
Copy the full SHA a399085View commit details -
Move all assignments out of Option.map() scopes
Co-authored-by: Jack Grigg <jack@electriccoin.co>
Configuration menu - View commit details
-
Copy full SHA for acfc1be - Browse repository at this point
Copy the full SHA acfc1beView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5497e15 - Browse repository at this point
Copy the full SHA 5497e15View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4948479 - Browse repository at this point
Copy the full SHA 4948479View commit details -
Configuration menu - View commit details
-
Copy full SHA for b0d04f7 - Browse repository at this point
Copy the full SHA b0d04f7View commit details -
Configuration menu - View commit details
-
Copy full SHA for e539720 - Browse repository at this point
Copy the full SHA e539720View commit details -
Remove misleading column names at top-level config.
The EccConfig only knows about 10 generic advice columns. These columns are renamed by individual components (e.g. AddConfig, MulConfig). The mapping for each individual config is captured in its impl From<EccConfig>.
Configuration menu - View commit details
-
Copy full SHA for 9beaf68 - Browse repository at this point
Copy the full SHA 9beaf68View commit details -
Add check for a corner case of fixed-base scalar multiplication that …
…requires a doubling. Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Configuration menu - View commit details
-
Copy full SHA for 13ebe78 - Browse repository at this point
Copy the full SHA 13ebe78View commit details -
Add check for a corner case of *short* fixed-base scalar multiplicati…
…on that requires a doubling. Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Configuration menu - View commit details
-
Copy full SHA for 381584f - Browse repository at this point
Copy the full SHA 381584fView commit details -
Inline equality assertions on values to individual components (flagged off with #[cfg(test)]. Move module-specific tests into respective modules.
Configuration menu - View commit details
-
Copy full SHA for dbb6120 - Browse repository at this point
Copy the full SHA dbb6120View commit details -
Configuration menu - View commit details
-
Copy full SHA for ffa3d6e - Browse repository at this point
Copy the full SHA ffa3d6eView commit details -
Configuration menu - View commit details
-
Copy full SHA for db95b5b - Browse repository at this point
Copy the full SHA db95b5bView commit details -
Remove EccLoaded struct and FixedPoint, FixedPointShort associated ty…
…pes. We do not load the fixed bases into a single location in the circuit; rather, they are assigned to fixed columns at the offsets where they need to be used. The EccLoaded struct was not storing any references to circuit variables. It was holding constants in memory which the caller can instead directly access. Similarly, there is no need to have the FixedPoint or FixedPointShort associated types in the EccInstructions trait, since these types do not contain references to circuit variables. The corresponding get_fixed() and get_fixed_short() instructions are also removed.
Configuration menu - View commit details
-
Copy full SHA for a90b7f0 - Browse repository at this point
Copy the full SHA a90b7f0View commit details -
mul_fixed: Remove MulFixed trait
This was defining shared behaviour between the mul_fixed::short and mul_fixed::full_width modules. But the behaviour can be captured by simply sharing the same mul_fixed::Config.
Configuration menu - View commit details
-
Copy full SHA for 9a8a81b - Browse repository at this point
Copy the full SHA 9a8a81bView commit details -
chip: Directly use ValueCommitV as FixedPointsShort associated type
There is no need to enumerate FixedPointsShort or to make a newtype, since ValueCommitV is the only fixed base used with short signed scalars.
Configuration menu - View commit details
-
Copy full SHA for a4f7128 - Browse repository at this point
Copy the full SHA a4f7128View commit details -
Configuration menu - View commit details
-
Copy full SHA for 218efa2 - Browse repository at this point
Copy the full SHA 218efa2View commit details -
witness_scalar_fixed: Use const generics to differentiate full-width …
…vs. short scalars
Configuration menu - View commit details
-
Copy full SHA for 9303f8b - Browse repository at this point
Copy the full SHA 9303f8bView commit details -
Configuration menu - View commit details
-
Copy full SHA for aeee55a - Browse repository at this point
Copy the full SHA aeee55aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 65ac816 - Browse repository at this point
Copy the full SHA 65ac816View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9c30463 - Browse repository at this point
Copy the full SHA 9c30463View commit details
Commits on Jun 5, 2021
-
Tests do not always use the MockProver.
Configuration menu - View commit details
-
Copy full SHA for 6d1059b - Browse repository at this point
Copy the full SHA 6d1059bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 63751fa - Browse repository at this point
Copy the full SHA 63751faView commit details