[WIP] Implement ECC chip #23
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## constants #23 +/- ##
==============================================
- Coverage 56.52% 37.98% -18.54%
==============================================
Files 16 17 +1
Lines 414 616 +202
==============================================
Hits 234 234
- Misses 180 382 +202
Continue to review full report at Codecov.
|
therealyingtong
force-pushed
the
ecc-chip
branch
3 times, most recently
from
1c0e877
to
3f5220f
Compare
therealyingtong
force-pushed
the
ecc-chip
branch
9 times, most recently
from
f775e2b
to
bd7dea7
Compare
therealyingtong
force-pushed
the
ecc-chip
branch
3 times, most recently
from
c316ef0
to
9fb3f56
Compare
therealyingtong
force-pushed
the
ecc-chip
branch
4 times, most recently
from
3d56a57
to
b5e8b46
Compare
therealyingtong
force-pushed
the
constants
branch
from
06b79c9
to
32cccbd
Compare
therealyingtong
force-pushed
the
ecc-chip
branch
4 times, most recently
from
44b30c5
to
0454694
Compare
We can generalise this in a later iteration to remove Orchard-specific assumptions.
therealyingtong
force-pushed
the
ecc-chip
branch
from
31aff86
to
faa88c6
Compare
[WIP] Fix ECC implementation to work with new Chip trait
therealyingtong
force-pushed
the
constants
branch
from
4805987
to
eb19ca2
Compare
therealyingtong
force-pushed
the
ecc-chip
branch
from
3a068cf
to
4016e7b
Compare
therealyingtong
commented
Apr 26, 2021
| mod witness_point; | ||
| mod witness_scalar_fixed; | ||
| mod witness_scalar_fixed_short; | ||
| mod witness_scalar_var; |
There was a problem hiding this comment.
We don't need to separately decompose ivk for variable-base scalar mul; we can merge the decomposition into the scalar mul.
therealyingtong
force-pushed
the
constants
branch
from
eb19ca2
to
de75c95
Compare
|
Superseded by optimised implementation (#73). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on #43 (Add Orchard constants) which is unmerged.
It also points to the
chip-configbranch zcash/halo2#253 which is unmerged onhalo2.