Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra report folders creation #1488

Closed
DimaGrinevich opened this issue Oct 14, 2021 · 2 comments · Fixed by #1498
Closed

Extra report folders creation #1488

DimaGrinevich opened this issue Oct 14, 2021 · 2 comments · Fixed by #1498
Labels
Milestone

Comments

@DimaGrinevich
Copy link
Contributor

Carina creates extra folders during run, because test report folder known only in one thread (private static final ThreadLocal testDirectory = new ThreadLocal(); in ReportContext) when driver do some actions in new thread, but connected with the same test. For example openURL in DriverHelper. There new thread created with Future<?> future = Executors.newSingleThreadExecutor().submit(new Callable() {}. Thats why every log in new thread is going to new report. and even if we delete all logs from call method, DriverListener also uses new thread and logs everything into new folder (screenshot from DriverListener goes to new folder too).

@vdelendik vdelendik added this to the 7.2.12 milestone Oct 14, 2021
@vdelendik vdelendik modified the milestones: 7.2.12, 7.2.13 Nov 7, 2021
vdelendik added a commit to Eldarian/carina that referenced this issue Nov 7, 2021
Eldarian added a commit to Eldarian/carina that referenced this issue Nov 9, 2021
@vdelendik vdelendik modified the milestones: 7.2.13, 7.2.14 Nov 17, 2021
Eldarian added a commit to Eldarian/carina that referenced this issue Nov 18, 2021
@vdelendik vdelendik modified the milestones: 7.2.14, 7.2.13 Nov 20, 2021
vdelendik added a commit that referenced this issue Nov 22, 2021
Fix extra report folders creation
@vdelendik
Copy link
Contributor

testing should be done using 7.2.14-SNAPHOT core version

@ghost
Copy link

ghost commented Dec 7, 2021

Verified by customer, fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants