Fix extra report folders creation #1498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vdelendik
reviewed
Nov 8, 2021
| @@ -128,6 +128,9 @@ public void onStart(ITestContext context) { | |||
|
|
|||
| @Override | |||
| public void onTestStart(ITestResult result) { | |||
| // create new folder for test report | |||
| ReportContext.createNewTestDir(); | |||
There was a problem hiding this comment.
rather incorrect method naming... it doesn't generate new test dir)
vdelendik
reviewed
Nov 8, 2021
| @@ -473,6 +473,12 @@ public static void emptyTestDirData() { | |||
| closeThreadLogAppender(); | |||
| } | |||
|
|
|||
| public static void createNewTestDir() { | |||
There was a problem hiding this comment.
why do we need this method?
vdelendik
reviewed
Nov 18, 2021
| @@ -128,7 +128,10 @@ public void onStart(ITestContext context) { | |||
|
|
|||
| @Override | |||
| public void onTestStart(ITestResult result) { | |||
| // create new folder for test report | |||
| ReportContext.createNewTestDir(StringUtils.EMPTY); | |||
There was a problem hiding this comment.
- rename to createTestDir
- implement 2 methods: one without args -> UUID for naming, and with actual parameter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1488
Added functionality that creates test report folder on test start manually.
testDirectoryis nowInheritableThreadLocalvariable. When there is a new thread created while test runs, initial value oftestDirectoryis the same as at the parent thread.ThreadLogAppender now checks does bufferedWriter logs to current test directory.
Info logs work correctly, in debug log layer I found that some extra folders still arriving: for example,
OnAfterClass(because TestLogAppender has already closed) and for running shutdown hook (because this log appears from special thread)