Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Panel drag available under Project Panel menu items #10017

Closed
1 task done
Moshyfawn opened this issue Mar 31, 2024 · 3 comments · Fixed by #10035
Closed
1 task done

Panel drag available under Project Panel menu items #10017

Moshyfawn opened this issue Mar 31, 2024 · 3 comments · Fixed by #10035
Labels
defect [core label] menus Feedback for menu items, context menus, etc mouse interaction Feedback for mouse interaction states, actions, etc regression A bug that was introduced in a recent release workspace Feedback for workspace management, layout, interactions, etc

Comments

@Moshyfawn
Copy link
Member

Check for existing issues

  • Completed

Describe the bug / provide steps to reproduce it

As in #9501, the drag crusor type is displayed when the mouse pointer is over a file actions menu and dragging the panel is available. The expected behaviour would be to disable panel dragging when the menu is open.

Environment

Zed: v0.130.0 (Zed Nightly 3c8b376)
OS: macOS 14.4.1
Memory: 16 GiB
Architecture: aarch64

If applicable, add mockups / screenshots to help explain present your vision of the feature

zed-hover-propagate

If applicable, attach your ~/Library/Logs/Zed/Zed.log file to this issue.

No response
@Moshyfawn Moshyfawn added defect [core label] mouse interaction Feedback for mouse interaction states, actions, etc workspace Feedback for workspace management, layout, interactions, etc project panel Feedback for files tree view menus Feedback for menu items, context menus, etc admin read Pending admin review labels Mar 31, 2024
@Moshyfawn
Copy link
Member Author

I can't seem to reproduce this in the latest Preview, so I'll add the regression label as well.

@Moshyfawn Moshyfawn added regression A bug that was introduced in a recent release and removed project panel Feedback for files tree view labels Mar 31, 2024
@bennetbo
Copy link
Collaborator

bennetbo commented Apr 1, 2024

Looks like #9911 caused the regression

@bennetbo bennetbo mentioned this issue Apr 1, 2024
Merged
@bennetbo
Copy link
Collaborator

bennetbo commented Apr 1, 2024

Thanks for the report, should be fixed in #10035.

bennetbo added a commit that referenced this issue Apr 1, 2024
@bennetbo
Fix panel drag leaking through overlay (#10035)
c126fdb 
Closes #10017. While reworking the `overlay` element in #9911, I did not
realize that all overlay elements called `defer_draw` with a priority of
`1`.

/cc @as-cii 

Not including release notes, since it was only present in nightly.

Release Notes:

- N/A
@JosephTLyons JosephTLyons removed the admin read Pending admin review label Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
defect [core label] menus Feedback for menu items, context menus, etc mouse interaction Feedback for mouse interaction states, actions, etc regression A bug that was introduced in a recent release workspace Feedback for workspace management, layout, interactions, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix panel drag leaking through overlay
3 participants
@Moshyfawn @JosephTLyons @bennetbo