Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pane resize available through expanded bottom panel #9501

Closed
1 task done
Moshyfawn opened this issue Mar 18, 2024 · 3 comments · Fixed by #9909
Closed
1 task done

Pane resize available through expanded bottom panel #9501

Moshyfawn opened this issue Mar 18, 2024 · 3 comments · Fixed by #9909
Labels
defect [core label] panel Feedback for panels. Panels are the content that fills the docks. terminal Feedback for terminal integration, shell commands, etc workspace Feedback for workspace management, layout, interactions, etc

Comments

@Moshyfawn
Copy link
Member

Check for existing issues

  • Completed

Describe the bug / provide steps to reproduce it

When the bottom panel is expanded to full screen, the panels below it can still be resized. The expected behaviour is that the resize cursor doesn't appear and panes can't be resized if they are under the bottom panel.

Environment

Zed: v0.127.1 (Zed Preview)
OS: macOS 14.4.0
Memory: 16 GiB
Architecture: aarch64

If applicable, add mockups / screenshots to help explain present your vision of the feature

zed-resize-through.mp4

If applicable, attach your ~/Library/Logs/Zed/Zed.log file to this issue.

No response
@Moshyfawn Moshyfawn added defect [core label] terminal Feedback for terminal integration, shell commands, etc workspace Feedback for workspace management, layout, interactions, etc admin read Pending admin review panel Feedback for panels. Panels are the content that fills the docks. labels Mar 18, 2024
@JosephTLyons JosephTLyons removed the admin read Pending admin review label Mar 26, 2024
@osiewicz
Copy link
Contributor

I can't repro it on the latest nightly. You can still resize the panes by grabbing a divider above the terminal, but I can't do it on the terminal itself.

@Moshyfawn
Copy link
Member Author

Moshyfawn commented Mar 27, 2024 •
edited
Loading

I'm still seeing it in Zed Nightly 0.129.0 🤔

zed-nightly-drag.mp4

@osiewicz
Copy link
Contributor

Oh, I see! I can indeed repro it too.

I was trying to resize the pane divider, whereas here it's the vertical panel divider that's leaking through.

@osiewicz osiewicz mentioned this issue Mar 28, 2024
Merged
osiewicz added a commit that referenced this issue Mar 28, 2024
@osiewicz
workspace: Fix panel resize handles leaking through zoomed panels (#9909
cb7c53b 
)

Fixes #9501 

Release Notes:

- Fixed panel resize handle "leaking through" into a zoomed panel or
pane.
@Moshyfawn Moshyfawn mentioned this issue Mar 31, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
defect [core label] panel Feedback for panels. Panels are the content that fills the docks. terminal Feedback for terminal integration, shell commands, etc workspace Feedback for workspace management, layout, interactions, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

workspace: Fix panel resize handles leaking through zoomed panels zed-industries/zed
3 participants
@Moshyfawn @JosephTLyons @osiewicz