-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid unwrap in file finder #18374
Avoid unwrap in file finder #18374
Conversation
I just came across this tracking down this crash. I get this extremely consistently in 0.154.2 and it's extremely simply in one of my projects to reproduce. I'm not sure the release process, but it'd be great to get this into 0.154.3 since this has basically completely broken Cmd+P for me. :) I doubt this isn't something you're unaware of, but here's the full stacktrace for posterity and to help others potentially find this:
|
Sounds very sad, sorry for spoiling this. Will pick the code for the new release, but no promises when that gets released — I'll wait for more fixes just in case something appears by the end of the day. |
Release Notes: - Fixed a (rare) panic in file finder --------- Co-authored-by: Kirill Bulatov <kirill@zed.dev>
Release Notes: - Fixed a (rare) panic in file finder --------- Co-authored-by: Kirill Bulatov <kirill@zed.dev>
…reee * origin/main: git blame gutter: Use smallest possible space (zed-industries#18145) Fix minimum gutter line number spacing (zed-industries#18021) terraform: Bump to v0.1.1 (zed-industries#18382) lsp: Do not notify all language servers on file save (zed-industries#17756) Remove leftover println statements (zed-industries#18389) Fix `use_on_type_format` setting being unused per language (zed-industries#18387) Avoid panic by only restoring workspace if UI has launched (zed-industries#18386) Fix Typo in rust language guide (zed-industries#18383) editor: Fix cursor shape not restoring when setting removed (zed-industries#18379) Avoid unwrap in file finder (zed-industries#18374)
0.154.3 has been stable so far! Thank you. <3 |
Release Notes: - Fixed a (rare) panic in file finder --------- Co-authored-by: Kirill Bulatov <kirill@zed.dev>
Release Notes: