Avoid panic by only restoring workspace if UI has launched #18386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should fix the `unregistered setting type workspace::workspace_settings::WorkspaceSettings` panic that came from inside `restorable_workspace_locations`. We tracked it down to a possible scenario (we can't recreate it though) in which `app.on_reopen` is called before the app has finished launching. In any case, this check makes sense, because we only want to restore a workspace in case the whole app has launched with a UI. Co-authored-by: Bennet <bennet@zed.dev>
cla-bot
bot
added
the
cla-signed
schpet
added a commit
to schpet/zed
that referenced
this pull request
Sep 27, 2024
…reee * origin/main: git blame gutter: Use smallest possible space (zed-industries#18145) Fix minimum gutter line number spacing (zed-industries#18021) terraform: Bump to v0.1.1 (zed-industries#18382) lsp: Do not notify all language servers on file save (zed-industries#17756) Remove leftover println statements (zed-industries#18389) Fix `use_on_type_format` setting being unused per language (zed-industries#18387) Avoid panic by only restoring workspace if UI has launched (zed-industries#18386) Fix Typo in rust language guide (zed-industries#18383) editor: Fix cursor shape not restoring when setting removed (zed-industries#18379) Avoid unwrap in file finder (zed-industries#18374)
noaccOS
pushed a commit
to noaccOS/zed
that referenced
this pull request
Oct 19, 2024
…tries#18386) This should fix the `unregistered setting type workspace::workspace_settings::WorkspaceSettings` panic that came from inside `restorable_workspace_locations`. We tracked it down to a possible scenario (we can't recreate it though) in which `app.on_reopen` is called before the app has finished launching. In any case, this check makes sense, because we only want to restore a workspace in case the whole app has launched with a UI. Release Notes: - N/A Co-authored-by: Bennet <bennet@zed.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the
unregistered setting type workspace::workspace_settings::WorkspaceSettingspanic that came from insiderestorable_workspace_locations.We tracked it down to a possible scenario (we can't recreate it though) in which
app.on_reopenis called before the app has finished launching.In any case, this check makes sense, because we only want to restore a workspace in case the whole app has launched with a UI.
Release Notes: