-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vue: Use latest available @vue/language-server package #18807
vue: Use latest available @vue/language-server package #18807
Conversation
We require contributors to sign our Contributor License Agreement, and we don't have @rowanwins on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
@cla-bot check |
We require contributors to sign our Contributor License Agreement, and we don't have @rowanwins on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
The cla-bot has been summoned, and re-checked this pull request! |
Last I checked, there were changes in v2 of the Vue language server that broke certain aspects of the functionality:
It's possible that they have remedied this since last I looked, but we'll need to do due diligence to make sure all of the workloads are still working as expected. |
I don't know the full context, but upstream claims this issue volarjs/volar.js#186 was fixed by vuejs/repl@f9f650a. |
@cla-bot check |
The cla-bot has been summoned, and re-checked this pull request! |
@rowanwins any news? |
We've moved the Vue extension over to zed-extensions/vue in #19426. If you pick this back up, you can open a PR over there. |
Copied from: zed-industries/zed#18807 (comment) Authored by @rowanwins
This PR relates to #9846 which pinned the @vue/language-server package to a version approximately 12 months old. This PR brings behaviour inline with how other JS language extensions works by pulling the latest available package.
I have tested on Zed 0.155.2 and it now seems to be behaving.
Release Notes: