Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vue: Use latest available @vue/language-server package #18807

Closed

Conversation

rowanwins
Copy link

@rowanwins rowanwins commented Oct 7, 2024

This PR relates to #9846 which pinned the @vue/language-server package to a version approximately 12 months old. This PR brings behaviour inline with how other JS language extensions works by pulling the latest available package.

I have tested on Zed 0.155.2 and it now seems to be behaving.

Release Notes:

  • N/A

Copy link

cla-bot bot commented Oct 7, 2024

We require contributors to sign our Contributor License Agreement, and we don't have @rowanwins on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

@rowanwins
Copy link
Author

@cla-bot check

Copy link

cla-bot bot commented Oct 7, 2024

We require contributors to sign our Contributor License Agreement, and we don't have @rowanwins on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

Copy link

cla-bot bot commented Oct 7, 2024

The cla-bot has been summoned, and re-checked this pull request!

@maxdeviant maxdeviant changed the title Use latest available @vue/language-server package vue: Use latest available @vue/language-server package Oct 7, 2024
@maxdeviant maxdeviant self-assigned this Oct 7, 2024
@maxdeviant
Copy link
Member

maxdeviant commented Oct 7, 2024

Last I checked, there were changes in v2 of the Vue language server that broke certain aspects of the functionality:

The Vue bits of the language server work, but the TypeScript stuff doesn't. And they have a separate language server plugin you can use to add Vue support to tsserver, but then they also put out another release after v2 that added back the old built-in TypeScript support.

It's possible that they have remedied this since last I looked, but we'll need to do due diligence to make sure all of the workloads are still working as expected.

@notpeter
Copy link
Member

notpeter commented Oct 7, 2024

I don't know the full context, but upstream claims this issue volarjs/volar.js#186 was fixed by vuejs/repl@f9f650a.
Don't know if there were additional issues.

@rowanwins
Copy link
Author

@cla-bot check

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Oct 8, 2024
Copy link

cla-bot bot commented Oct 8, 2024

The cla-bot has been summoned, and re-checked this pull request!

@reslear
Copy link
Contributor

reslear commented Oct 10, 2024

@rowanwins any news?

@maxdeviant
Copy link
Member

We've moved the Vue extension over to zed-extensions/vue in #19426.

If you pick this back up, you can open a PR over there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants