-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pin Vue language server to 1.8 #9846
Conversation
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: qing.
|
f18c562
to
032e376
Compare
We require contributors to sign our Contributor License Agreement, and we don't have @Dunqing on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
@cla-bot check |
The cla-bot has been summoned, and re-checked this pull request! |
Hey! Thanks for this. Did you check that 1.8 does work? |
Yes. I tested. That's work |
Great! Thank you! I updated the release notes and will merge. |
How downgrade a version of Volar? Thank you. |
How downgrade a version of 1.8?Thanks. |
This fix is in the preview release right now: https://zed.dev/releases/preview/0.129.1 When you run that, it should automatically use the specified Vue language server. |
Apparently both the issues were preventing Zed to unpin Volar from 1.8 have been resolved. Does anything else need to be address to achieve this? Is there anyway we can help? |
@Readpato Happy to review PRs! 😉 |
Time to learn Rust, I guess! I will try to open a PR. Would it suffice for this PR to revert back the changes that @Dunqing overwrote to pin the LSP into version 1.8? (I'll attach the code part that has been overwritten for clarification) and to test if the LSP actually works? [...]
vue_version: self
.node
.npm_package_latest_version("@vue/language-server")
.await?,
[...] Glad to give a hand :) |
After
@vue/language-server
release 2.0, vue lsp doesn't work. I tried to support 2.0, but since I'm not familiar with@vue/language-server
andzed
I was unsuccessful. To avoid long-term unavailability, I temporarily fixed the version to 1.8 until we have 2.0 support.Release Notes:
@vue/language-server
to version1.8
until Zed supports2.x
. (#9388 & #9329).