Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin Vue language server to 1.8 #9846

Merged
merged 2 commits into from
Mar 27, 2024

Conversation

Dunqing
Copy link
Contributor

@Dunqing Dunqing commented Mar 27, 2024

After @vue/language-server release 2.0, vue lsp doesn't work. I tried to support 2.0, but since I'm not familiar with @vue/language-server and zed I was unsuccessful. To avoid long-term unavailability, I temporarily fixed the version to 1.8 until we have 2.0 support.

Release Notes:

  • Pinned @vue/language-server to version 1.8 until Zed supports 2.x. (#9388 & #9329).

Copy link

cla-bot bot commented Mar 27, 2024

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: qing.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@Dunqing Dunqing force-pushed the fix/vue/lsp-not-work branch from f18c562 to 032e376 Compare March 27, 2024 10:16
Copy link

cla-bot bot commented Mar 27, 2024

We require contributors to sign our Contributor License Agreement, and we don't have @Dunqing on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

@Dunqing
Copy link
Contributor Author

Dunqing commented Mar 27, 2024

@cla-bot check

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Mar 27, 2024
Copy link

cla-bot bot commented Mar 27, 2024

The cla-bot has been summoned, and re-checked this pull request!

@mrnugget
Copy link
Member

Hey! Thanks for this. Did you check that 1.8 does work?

@Dunqing
Copy link
Contributor Author

Dunqing commented Mar 27, 2024

Hey! Thanks for this. Did you check that 1.8 does work?

Yes. I tested. That's work

@maxdeviant maxdeviant changed the title fix: vue lsp not work Pin Vue language server to 1.8 Mar 27, 2024
@mrnugget
Copy link
Member

Great! Thank you! I updated the release notes and will merge.

@mrnugget mrnugget merged commit 96b812b into zed-industries:main Mar 27, 2024
9 checks passed
@klyuk88
Copy link

klyuk88 commented Mar 30, 2024

How downgrade a version of Volar? Thank you.

@WalkAlone0325
Copy link

How downgrade a version of 1.8?Thanks.

@mrnugget
Copy link
Member

mrnugget commented Apr 2, 2024

This fix is in the preview release right now: https://zed.dev/releases/preview/0.129.1 When you run that, it should automatically use the specified Vue language server.

@Readpato
Copy link

Readpato commented Sep 30, 2024

Apparently both the issues were preventing Zed to unpin Volar from 1.8 have been resolved. Does anything else need to be address to achieve this? Is there anyway we can help?

@notpeter
Copy link
Member

notpeter commented Sep 30, 2024

@Readpato Happy to review PRs! 😉

@Readpato
Copy link

Readpato commented Oct 1, 2024

Time to learn Rust, I guess! I will try to open a PR.

Would it suffice for this PR to revert back the changes that @Dunqing overwrote to pin the LSP into version 1.8? (I'll attach the code part that has been overwritten for clarification) and to test if the LSP actually works?

[...]
vue_version: self
        .node
        .npm_package_latest_version("@vue/language-server")
        .await?,
[...]

Glad to give a hand :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants