AMM-CDA-7 Add event information for indexer for Hybrid Orderbook AMM #1288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chralt98
added
the
s:blocked
This was referenced Mar 14, 2024
mergify
bot
added
s:in-progress
Chralt98
changed the base branch from
chralt98-amm-cda-event-compare
to
chralt98-amm-cda-release
Chralt98
changed the base branch from
chralt98-amm-cda-release
to
chralt98-amm-cda-event-compare
| @@ -122,13 +125,27 @@ mod pallet { | |||
| { | |||
| /// A trade was executed. | |||
| HybridRouterExecuted { | |||
| /// The type of transaction (Buy or Sell). | |||
There was a problem hiding this comment.
Are the fee amounts contained in the amount_* values? This should be clarified in the documentation.
Chralt98
changed the base branch from
chralt98-amm-cda-event-compare
to
chralt98-amm-cda-6-5
|
This pull request is now in conflicts. Could you fix it @Chralt98? 🙏 |
mergify
bot
added
s:revision-needed
mergify
bot
removed
the
s:in-progress
Chralt98
changed the base branch from
chralt98-amm-cda-6-5
to
chralt98-amm-cda-release
Chralt98
changed the base branch from
chralt98-amm-cda-release
to
chralt98-amm-cda-6-5
mergify
bot
added
s:in-progress
mergify
bot
added
s:in-progress
Chralt98
added
s:in-progress
mergify
bot
added
s:revision-needed
mergify
bot
added
s:in-progress
Base automatically changed from
chralt98-amm-cda-6-5
to
chralt98-amm-cda-release
March 29, 2024 06:32
|
Dropped in favor of this PR #1293 This was done, because the commit history here led to merged changes would have been needed to be reviewed again. |
Chralt98
added
s:abandoned
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
It adds necessary event information for the indexer and front end.
It contains aggregated amounts for the asset out, the related AMM trades and order book trades plus an optional order amount information, if an order was placed at the end.
What important points should reviewers know?
Is there something left for follow-up PRs?
What alternative implementations were considered?
Are there relevant PRs or issues?
References