Implement Hybrid Router #1307
Merged
Implement Hybrid Router #1307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* switch to AmmCdaHybrid enum field * Update zrml/parimutuel/src/tests/buy.rs Co-authored-by: Malte Kliemann <mail@maltekliemann.com> * Update zrml/parimutuel/src/tests/claim.rs Co-authored-by: Malte Kliemann <mail@maltekliemann.com> * Update zrml/parimutuel/src/tests/refund.rs Co-authored-by: Malte Kliemann <mail@maltekliemann.com> * Update storage version to 11 and add MigrateScoringRuleAmmCdaHybrid * Update primitives/src/market.rs * update migration --------- Co-authored-by: Malte Kliemann <mail@maltekliemann.com>
* glue everything together * add hybrid router to configuration * fix tests * fix conditional tests
…1293) * add event info * use slice as function parameter * update test amm amount out of event * fix order book tests * update documentation * removed dependency
…ok errors (#1294) * add event info * use slice as function parameter * update test amm amount out of event * wip * handle soft and hard failure * add order book soft failure * fix clippy * fix CI * remove swaps pallet dependency
|
This pull request is now in conflicts. Could you fix it @Chralt98? 🙏 |
mergify
bot
added
s:revision-needed
mergify
bot
added
s:in-progress
* wip * use asset conversions * adapt hybrid router to new asset system * apply review suggestions * fmt
Chralt98
added
s:review-needed
Chralt98
added
s:review-needed
Chralt98
added
s:in-progress
Chralt98
added
s:review-needed
maltekliemann
approved these changes
Apr 12, 2024
maltekliemann
added
s:accepted
sea212
added
i:spec-changed ⚠️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
It implements a router that manages the neo-swaps AMM and the order book for executing buy and sell trades.
What important points should reviewers know?
The following PRs were incorporated into this PR:
#1274
#1275
#1276
#1277
#1278
#1279
#1288
#1293
#1294
Is there something left for follow-up PRs?
What alternative implementations were considered?
Are there relevant PRs or issues?
References