-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix migration & it-tests for release-v0.5.4 #1356
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## release-v0.5.4 #1356 +/- ##
=================================================
Coverage ? 93.24%
=================================================
Files ? 133
Lines ? 29557
Branches ? 0
=================================================
Hits ? 27560
Misses ? 1997
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is currently missing tests. Can we add tests or is this scenario difficult to reproduce?
Also, I think if you're going to hardcode the market IDs, which I understand is a practical approach, you should make this a separate migration which we then only apply to Battery Station using the with-battery-station-runtime
feature.
Please also change the target branch to main
and then merge main
into the release branch after merging this feature branch.
Abandoned in favor of this PR #1357, because of the commit history that includes the version bumps, which should not be part of the merge to main. |
What does it do?
bool
flag toVERBOSE_LOG
to satisfy moonwallWhat important points should reviewers know?
Is there something left for follow-up PRs?
What alternative implementations were considered?
Are there relevant PRs or issues?
References