Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix migration & it-tests for release-v0.5.4 #1357

Merged
merged 5 commits into from
Aug 19, 2024

Conversation

Chralt98
Copy link
Member

What does it do?

  • Fix migration for battery station to remove markets, which fail to decode
  • Replace main-net RPC endpoint for try-runtime
  • Correct the pallet storage version for market-commons to match the newest version
  • added bool flag to VERBOSE_LOG to satisfy moonwall

What important points should reviewers know?

Is there something left for follow-up PRs?

What alternative implementations were considered?

Are there relevant PRs or issues?

References

@Chralt98 Chralt98 added the s:in-progress The pull requests is currently being worked on label Aug 14, 2024
@Chralt98 Chralt98 requested a review from sea212 as a code owner August 15, 2024 11:12
@Chralt98 Chralt98 added s:review-needed The pull request requires reviews and removed s:in-progress The pull requests is currently being worked on labels Aug 15, 2024
@codecov-commenter
Copy link

codecov-commenter commented Aug 15, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 94.64286% with 9 lines in your changes missing coverage. Please review.

Project coverage is 93.25%. Comparing base (6133ceb) to head (d238295).

Files Patch % Lines
zrml/market-commons/src/migrations.rs 94.64% 9 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #1357    +/-   ##
========================================
  Coverage   93.25%   93.25%            
========================================
  Files         133      133            
  Lines       29550    29709   +159     
========================================
+ Hits        27556    27706   +150     
- Misses       1994     2003     +9     
Flag Coverage Δ
tests 93.25% <94.64%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mergify mergify bot added s:in-progress The pull requests is currently being worked on and removed s:review-needed The pull request requires reviews labels Aug 16, 2024
@Chralt98 Chralt98 added s:review-needed The pull request requires reviews and removed s:in-progress The pull requests is currently being worked on labels Aug 16, 2024
@Chralt98 Chralt98 self-assigned this Aug 16, 2024
@Chralt98 Chralt98 added s:in-progress The pull requests is currently being worked on and removed s:review-needed The pull request requires reviews labels Aug 16, 2024
@Chralt98 Chralt98 added s:review-needed The pull request requires reviews and removed s:in-progress The pull requests is currently being worked on labels Aug 16, 2024
Copy link
Member

@maltekliemann maltekliemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job - looks great mod the one comment about storage reads! Will approve as soon as we can try-runtime this on Zeitgeist (should be Monday around noon).

zrml/market-commons/src/migrations.rs Outdated Show resolved Hide resolved
zrml/market-commons/src/migrations.rs Outdated Show resolved Hide resolved
@maltekliemann
Copy link
Member

try-runtime looks good on Zeitgeist. Also seems like no corrupted markets were created during the upgrade marathon.

@mergify mergify bot added s:in-progress The pull requests is currently being worked on and removed s:review-needed The pull request requires reviews labels Aug 19, 2024
@Chralt98 Chralt98 added s:review-needed The pull request requires reviews and removed s:in-progress The pull requests is currently being worked on labels Aug 19, 2024
@maltekliemann maltekliemann added s:accepted This pull request is ready for merge and removed s:review-needed The pull request requires reviews labels Aug 19, 2024
@mergify mergify bot merged commit b046f04 into main Aug 19, 2024
34 checks passed
@mergify mergify bot deleted the chralt98-fix-migration-and-it-tests branch August 19, 2024 13:59
@Chralt98 Chralt98 added this to the v0.5.4 milestone Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s:accepted This pull request is ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants