-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix migration & it-tests for release-v0.5.4 #1357
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1357 +/- ##
========================================
Coverage 93.25% 93.25%
========================================
Files 133 133
Lines 29550 29709 +159
========================================
+ Hits 27556 27706 +150
- Misses 1994 2003 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job - looks great mod the one comment about storage reads! Will approve as soon as we can try-runtime this on Zeitgeist (should be Monday around noon).
try-runtime looks good on Zeitgeist. Also seems like no corrupted markets were created during the upgrade marathon. |
What does it do?
bool
flag toVERBOSE_LOG
to satisfy moonwallWhat important points should reviewers know?
Is there something left for follow-up PRs?
What alternative implementations were considered?
Are there relevant PRs or issues?
References