fix(tab-bar): fix tab bar click when tabs are collapsed, fix tab bar length calculation #1658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I split it into two commits, but let me know if you'd prefer this squashed. |
imsnif
approved these changes
Sep 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1603 , as well as another bigger issue. I noticed that clicking on a tab used index in the linepart vector, which will be incorrect for every tab if there's collapsed tabs. We have to save tab index in LinePart, and then use that to switch tabs.
Clicking on the collapsed tabs brings the user to the first hidden tab on that side.
Fixing the issue in #1603 was as discussed in the issue, as well switching the click comparison to be
click >= length && click < lengthinstead ofclick > length && click <= length