Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(compact-bar): mouse-click in simplified-ui #1917

Merged
merged 2 commits into from
Nov 17, 2022
Merged

fix(compact-bar): mouse-click in simplified-ui #1917

merged 2 commits into from
Nov 17, 2022

Conversation

imsuck
Copy link
Contributor

@imsuck imsuck commented Nov 9, 2022

Same changes as #1658 but for the compact-bar plugin.

@imsuck
Copy link
Contributor Author

imsuck commented Nov 10, 2022

How did the test case cannot_split_terminals_vertically_when_active_terminal_is_too_small fail when I'm just editing the source code of a plugin?

@imsnif imsnif mentioned this pull request Nov 15, 2022
Closed
@jaeheonji jaeheonji linked an issue Nov 15, 2022 that may be closed by this pull request
Incorrect calculation of tab length in simplified ui in compact-bar plugin #1868
Closed
@imsuck imsuck temporarily deployed to cachix November 15, 2022 13:25 Inactive
@jaeheonji
Copy link
Member

@imsuck Hey, Sorry for the late reply.

Do you want to find the source code that leads to the failure of that test case?
Do I understand that correctly?

@imsuck
Copy link
Contributor Author

imsuck commented Nov 16, 2022

@jaeheonji I was wondering how did it fail in my PR but not in #1658

@imsuck imsuck temporarily deployed to cachix November 16, 2022 09:58 Inactive
@jaeheonji
Copy link
Member

@imsuck

I was wondering how did it fail in my PR but not in #1658

That's weird. Could you please create an issue if the problem persists?

jaeheonji
jaeheonji reviewed Nov 16, 2022
View reviewed changes
Copy link
Member

@jaeheonji jaeheonji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Anything else to update?

@jaeheonji jaeheonji mentioned this pull request Nov 17, 2022
Closed
@jaeheonji jaeheonji merged commit a001833 into zellij-org:main Nov 17, 2022
@imsuck imsuck deleted the fix/compact-bar branch November 17, 2022 14:09
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaeheonji jaeheonji jaeheonji left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect calculation of tab length in simplified ui in compact-bar plugin
2 participants
@imsuck @jaeheonji