feat(ui): status bar redesign #3475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tomcat-42
pushed a commit
to Tomcat-42/zellij
that referenced
this pull request
Nov 9, 2024
* work * work * working * get default mode from server and some ui responsiveness * work * finish design and get tests to pass * get e2e tests to pass * add classic layout * add classic layout assets * fix e2e tests * style(fmt): rustfmt * fix plugin system test * style(fmt): some cleanups
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a redesign of the default status-bar plugin in order to accommodate the new non-colliding-keybindings setup (upcoming). This redesign also improves upon the user experience when using the default keybindings. For those who do not like the new default UI, it's possible to load the old one with
zellij -l classic. Thecompactlayout remains unchanged.Main changes for the default configuration + keybindings
floatingtoggle (now also included in the default configuration keybindings)Base-mode Awareness (unlock-first)
Many users have been working around the "colliding keybindings" problem by setting their base mode to
LOCKEDand unlocking it when they wanted to perform actions in the Zellij UI. With this change, the Zellij UI is now aware of this configuration method and provides helpful guidelines to indicate this to the user:Context and upcoming steps
This PR is a continuation of the work in #3422 and #3383. The ultimate goal is to provide a toggleable-at-runtime solution for the colliding keys problem, allowing the user to either:
The next PRs will tie up this solution together with some sort of UI configuration interface (which will also show the various runtime tips that have been removed in this PR).