feat(ui): configuration screen + configure non-colliding keys at runtime #3502
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a configuration screen that currently allows us to configure non-colliding keys at runtime (triggered by default now with
Ctrl o
+c
).Through this configuration screen, we are now also able to change the leader keys to either the default config or the new non-colliding config.
In the future, we'll be able to change the entire application config from this screen at runtime, as well as optionally save it so that it persists between sessions.
This PR changes the "rebind_keys" API call to "reconfigure" to reflect the fact that it will gradually accept an entire KDL configuration to override that of the current session. Right now, "reconfigure" supports "keybinds" and "default_mode".
Context
This is almost the last PR in the effort to solve the "colliding keybindings" problem. Some previous related PRs: #3422, #3383, #3475
The last piece left which will be added in an upcoming PR is to allow saving these configuration changes to disk so that they persist between sessions (right now they are limited to the current session).