Skip to content
This repository has been archived by the owner on May 1, 2019. It is now read-only.

Enhancement: Run PHP_CodeSniffer on Travis #211

Merged
merged 3 commits into from
Dec 3, 2014
Merged

Enhancement: Run PHP_CodeSniffer on Travis #211

merged 3 commits into from
Dec 3, 2014

Conversation

localheinz
Copy link
Member

This PR

  • adds squizlabs/php_codesniffer as a development dependency
  • updates .travis.yml to run phpcs instead of php-cs-fixer
  • adds fixes of CS violations with phpcbf

Related to zendframework/zendframework#6182.

@localheinz localheinz changed the title Feature/phpcs Feature: Run PHP_CodeSniffer on Travis Nov 18, 2014
@localheinz
Copy link
Member Author

@ezimuel @weierophinney

Seems there are no builds running at all. Can either of you please have a look and re-enable Travis for this repository?

@localheinz localheinz force-pushed the feature/phpcs branch 2 times, most recently from de1e438 to b453ac2 Compare November 18, 2014 18:01
@Ocramius
Copy link
Member

This should probably be rebased on top of #187

@localheinz
Copy link
Member Author

@Ocramius

Any plans on when #187 is going to get merged?

@Ocramius
Copy link
Member

Any plans on when #187 is going to get merged?

When somebody gets it running: I couldn't manage to get there.

@localheinz
Copy link
Member Author

@Ocramius

Me neither. Is anyone going to review that branch? It seems like a pain, given the change set.

@Ocramius
Copy link
Member

I did a review some time ago. I think @puphpet is just causing a huge mess of a diff there. :-(

@localheinz localheinz changed the title Feature: Run PHP_CodeSniffer on Travis Enhancement: Run PHP_CodeSniffer on Travis Nov 19, 2014
@localheinz localheinz mentioned this pull request Nov 19, 2014
Merged
4 tasks
@localheinz localheinz changed the title Enhancement: Run PHP_CodeSniffer on Travis [WIP] Enhancement: Run PHP_CodeSniffer on Travis Dec 1, 2014
@localheinz localheinz changed the title [WIP] Enhancement: Run PHP_CodeSniffer on Travis Enhancement: Run PHP_CodeSniffer on Travis Dec 2, 2014
localheinz
localheinz reviewed Dec 2, 2014
View reviewed changes
module/ZfModule/src/ZfModule/Service/Module.php
return false;
}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GeeH

If you get a chance to look at this line right here - apart from all the CS fixes applied in this commit, there was an issue with a brace being opened, but never closed.

@GeeH
Copy link
Contributor

GeeH commented Dec 3, 2014

I don't understand how this could have passed the build without a closing } ???

@localheinz
Copy link
Member Author

@GeeH

No tests! :trollface:

@localheinz
Copy link
Member Author

@GeeH

Rebased, waiting to be merged.

GeeH added a commit that referenced this pull request Dec 3, 2014
@GeeH
Merge pull request #211 from localheinz/feature/phpcs
61b94b1 
Enhancement: Run PHP_CodeSniffer on Travis
@GeeH GeeH merged commit 61b94b1 into zendframework:master Dec 3, 2014
@localheinz localheinz deleted the feature/phpcs branch December 7, 2014 13:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
Feature medium priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@localheinz @Ocramius @GeeH