Skip to content
This repository has been archived by the owner on May 1, 2019. It is now read-only.

Enhancement: Run phpmd on Travis #217

Merged
merged 5 commits into from
Dec 13, 2014
Merged

Conversation

localheinz
Copy link
Member

This PR

  • adds phpmd/phpmd as a development dependency
  • updates .travis.yml to run phpmd
  • fixes fixable warnings reported by phpmd
  • suppresses unfixable warnings reported by phpmd

Related to and blocked by #211.

@localheinz localheinz changed the title Enhancement: Run phpmd on Travis [WIP] Enhancement: Run phpmd on Travis Dec 1, 2014
@localheinz localheinz changed the title [WIP] Enhancement: Run phpmd on Travis Enhancement: Run phpmd on Travis Dec 13, 2014
GeeH added a commit that referenced this pull request Dec 13, 2014
Enhancement: Run phpmd on Travis
@GeeH GeeH merged commit 4225e50 into zendframework:master Dec 13, 2014
@GeeH
Copy link
Contributor

GeeH commented Dec 13, 2014

Why are you assigning a closed and merged PR to me @Ocramius ?

@@ -77,6 +77,9 @@ public function findByLike($query, $limit = null, $orderBy = null, $sort = 'ASC'
return $entity;
}

/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
g */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

g?

@localheinz localheinz deleted the feature/phpmd branch December 14, 2014 21:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants