This repository has been archived by the owner on May 1, 2019. It is now read-only.
Fix: added github repo exists check #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (!$result) { | ||
| $repository = $this->repositoryRetriever->getUserRepositoryMetadata($vendor, $module); | ||
|
|
||
| if (!$result || !$repository) { | ||
| $this->getResponse()->setStatusCode(Http\Response::STATUS_CODE_404); | ||
| return; |
There was a problem hiding this comment.
You should return the response here to short circuit the rest of the dispatch process.
There was a problem hiding this comment.
yeah will recode the logic so in case a repository is not exists we can save 1 api call
|
I think it's absolutely appropriate that our site 404s if the github repo doesn't exists. In an ideal world we would remove the module from our DB too (or flag it as hidden). |
|
the only problem i see what if the github api is down this would leed to a repository false flag - maybe some crontab that checks flagged repos once a week and delete them from the db |
GeeH
added a commit
that referenced
this pull request
Jan 24, 2015
Fix: added github repo exists check
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #182
fixes #158
but we need a solution in the future where such repos gets deleted from the db