Fix: View helper should actually be a controller plugin

[localheinz]

This PR

• turns a view helper which should be a controller plugin into a controller plugin
• implements an extension of the ZfcUser\Controller\UserController in order to set view variables in the view model returned from the indexAction()

[Ocramius]

@localheinz needs a rebase

[localheinz]

Rebased, @Ocramius! Thank you for the review.

[Ocramius]

I don't actually agree with this. Why was it moved to a controller plugin? What's the rationale behind it?

[localheinz]

As far as I can see from what the view helper does:

• it accesses the database layer
• it makes calls to an external API
• it returns an array of data

As far as my experience goes, these are all things I would never expect from a view helper.

Instead, I would see the responsibility of a view helper in accepting some data and preparing it for presentation in the view, for example, by applying some formatting or filling the data into a view template.

Please note that, as far as I can see, I wouldn't even create a controller plugin just yet, as it's only ever used once. Instead, I'd probably leave it to a service.

This was just the smallest refactoring possible, I believe.

[Ocramius]

these are all things I would never expect from a view helper

I disagree with this, but I also see why you'd think that. As long as these are all read operations, IMO it's fine to have them in view helpers. Yes, they sould not cause changes/events to be triggered.

Instead, I'd probably leave it to a service

Possibly a good solution, yes.

[localheinz]

@Ocramius

Also see #308.

[Ocramius]

This controller has no associated tests

[Ocramius]

Once the missing tests are introduced (integration with @coversNothing is fine) I can merge. I'm fine with the current approach after discussion.

[localheinz]

@Ocramius

Added a test for the case when the authentication service has no identity.

Tried to add a test for the success case and have almost been mocking myself to death and/or trying to detach listeners, still getting failing tests because of that.

[Ocramius]

I think mocking $listModule as function () {...} is enough

[Ocramius]

(if it makes your life easier: otherwise, current approach is fine)

[localheinz]

@Ocramius

I think mocking $listModule as function () {...} is enough

Doesn't work, as PluginManager is validating and asking for an implementation of Zend\Mvc\Controller\Plugin\PluginInterface. However, I mocked out all of the view helpers giving me a headache, tests should pass now!

[Ocramius]

Grrr @ PluginManager.

Yeah, mocking controllers is a mess

[Ocramius]

@localheinz let it be merged!

[localheinz]

😊