Fix: Move plugin functionality into appropriate service

[localheinz]

This PR

• moves the functionality of the ZfModule\Mvc\Controller\Plugin\ListModule controller plugin into ZfModule\Service\Module as this seems to be the appropriate service (same dependencies as the plugin)
• creates a factory for User\Controller\UserController and injects the the aforementioned service
• creates an alias for the zfcuser controller so we can actually use a factory
• adds a bunch of tests for Service\Module::listModule() so we can move on and refactor
• extracts Service\Module::listAllModules() and Service\Module::listUserModules() from Service\Module::listModule(), removes the latter
• renames methods

Follows #362, especially #362 (comment).

💡 Not sure about renaming methods, but to be honest, I have recently gotten tired of all of this getFoo() and setBar() stuff, does it make sense?

[localheinz]

Need to alias, otherwise the configuration of https://github.com/ZF-Commons/ZfcUser/blob/1.0.0/config/module.config.php#L8-L12 kicks in.

[localheinz]

@Ocramius

While I am at it, I would like to remove the options, since there's only one call to this method (YAGNI), but maybe you prefer a separate PR? Still in the mood for cleaning things before moving on to actually implementing new features.

[Ocramius]

@localheinz why not just providing a custom method? Cleaner and more expressive, IMO

[localheinz]

@Ocramius

Wait till I finish my taxes, will follow up with a separate PR!

[Ocramius]

@localheinz much better :-)

[localheinz]

@Ocramius

Glad you like it!

[localheinz]

@Ocramius

Added tests for Service\Module::listModule() and refactored the code a bit, please have a look!

[Ocramius]

Isn't current_user hitting the modules.zendframework.com user token's user?

[localheinz]

@Ocramius

To be honest, I have no idea, haven't had much of a look at the API yet. But I'm sure that @ins0 has. Nonetheless, this should be a separate issue.

[localheinz]

@Ocramius

I'd assume, though, that this refers to the currently authenticated user, no?

Edit

See this:

modules.zendframework.com/module/Application/src/Application/Service/RepositoryRetriever.php

Lines 119 to 129 in 9bad766

	/**
	* Return all Repositories from current authenticated GitHub User
	*
	* @param array $params
	*
	* @return RepositoryCollection
	*/
	public function getAuthenticatedUserRepositories($params = [])
	{
	return $this->githubClient->api('current_user')->repos($params);
	}

[Ocramius]

Yes, and that is very weird: the service keeps a reference to the user in the auth service? (you see where I'm going with this...)

[ins0]

jep current_user will request the user repositorys from the current linked github account of a user

[Ocramius]

$this->someService->getUserRepos(); would still need the $user ;-)

[ins0]

@Ocramius
one more try 😃

$userRepoInDb = $this->someService->getUserRepos($this->identity());
foreach($userRepoInDb as $repository){
        $repoData = $this->repositoryRetreiver->getRepositoryMetaData($identity->getUsername(), $repository->getName());
       // do stuff check for etc?
}

[Ocramius]

Yes, that's the stuff

[ins0]

thanks for your explanation @Ocramius

[localheinz]

@Ocramius @ins0

How about this PR, then, are you fine with it?

[ins0]

👍 looks good!

[Ocramius]

@localheinz merged, thanks!

[localheinz]

Thank you for reviewing, @Ocramius and @ins0!