Skip to content
This repository has been archived by the owner on May 1, 2019. It is now read-only.

Fix: When validating repositories, attempt to find by html_url, not by name #393

Merged
merged 2 commits into from
Feb 17, 2015
Merged

Fix: When validating repositories, attempt to find by html_url, not by name #393

merged 2 commits into from
Feb 17, 2015

Conversation

localheinz
Copy link
Member

This PR

  • enhances tests covering ZfModule\Service\Module by re-using repository provider method repository()
  • fixes an issue where when validating repositories fetched from GitHub, the mapper would look up modules by name, not url, and in result, render other's modules under your account

Fixes #128.
Fixes #199.
Fixes #246.

Steps required to reproduce

Before

screen shot 2015-02-17 at 22 52 27

After

screen shot 2015-02-17 at 23 15 57

@localheinz
Copy link
Member Author

/cc @ins0

@localheinz localheinz changed the title [WIP] Fix: When validating repositories, attempt to find by html_url, not by name Fix: When validating repositories, attempt to find by html_url, not by name Feb 17, 2015
Ocramius added a commit that referenced this pull request Feb 17, 2015
@Ocramius
Merge pull request #393 from localheinz/fix/not-my-module
c99bc9d 
Fix: When validating repositories, attempt to find by html_url, not by name
@Ocramius Ocramius merged commit c99bc9d into zendframework:master Feb 17, 2015
@Ocramius
Copy link
Member

@localheinz merged, thanks!

@localheinz
Copy link
Member Author

That was quick, @Ocramius, thank you!

@localheinz localheinz deleted the fix/not-my-module branch February 17, 2015 22:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@Ocramius Ocramius

Labels
Feature low priority
Projects
None yet
Milestone
No milestone
2 participants
@localheinz @Ocramius