Fix: When validating repositories, attempt to find by html_url, not by name

module/ZfModule/src/ZfModule/Service/Module.php

@@ -133,7 +133,7 @@ public function currentUserModules()
                 continue;
             }
 
-            $module = $this->moduleMapper->findByName($repository->name);
+            $module = $this->moduleMapper->findByUrl($repository->html_url);
             if (!($module instanceof Entity\Module)) {
                 continue;
             }

module/ZfModule/test/ZfModuleTest/Service/ModuleTest.php

@@ -81,13 +81,7 @@ public function testListAllModulesWithArgumentListsModulesFromDatabaseLimited()
 
     public function testListUserModulesListsCurrentUsersModulesFromApiFoundInDatabase()
     {
-        $name = 'foo';
-
-        $repository = new stdClass();
-        $repository->fork = false;
-        $repository->permissions = new stdClass();
-        $repository->permissions->push = true;
-        $repository->name = $name;
+        $repository = $this->repository();
 
         $module = $this->getMockBuilder(Entity\Module::class)->getMock();
 
@@ -99,8 +93,8 @@ public function testListUserModulesListsCurrentUsersModulesFromApiFoundInDatabas
 
         $moduleMapper
             ->expects($this->once())
-            ->method('findByName')
-            ->with($this->equalTo($name))
+            ->method('findByUrl')
+            ->with($this->equalTo($repository->html_url))
             ->willReturn($module)
         ;
 
@@ -135,16 +129,15 @@ public function testListUserModulesListsCurrentUsersModulesFromApiFoundInDatabas
 
     public function testListUserModulesDoesNotLookupModulesFromApiWhereUserHasNoPushPrivilege()
     {
-        $repository = new stdClass();
-        $repository->fork = false;
-        $repository->permissions = new stdClass();
+        $repository = $this->repository();
+
         $repository->permissions->push = false;
 
         $moduleMapper = $this->getMockBuilder(Mapper\Module::class)->getMock();
 
         $moduleMapper
             ->expects($this->never())
-            ->method('findByName')
+            ->method('findByUrl')
         ;
 
         $currentUserService = $this->getMockBuilder(Api\CurrentUser::class)->getMock();
@@ -178,14 +171,15 @@ public function testListUserModulesDoesNotLookupModulesFromApiWhereUserHasNoPush
 
     public function testListUserModulesDoesNotLookupModulesFromApiThatAreForks()
     {
-        $repository = new stdClass();
+        $repository = $this->repository();
+
         $repository->fork = true;
 
         $moduleMapper = $this->getMockBuilder(Mapper\Module::class)->getMock();
 
         $moduleMapper
             ->expects($this->never())
-            ->method('findByName')
+            ->method('findByUrl')
         ;
 
         $currentUserService = $this->getMockBuilder(Api\CurrentUser::class)->getMock();
@@ -219,20 +213,14 @@ public function testListUserModulesDoesNotLookupModulesFromApiThatAreForks()
 
     public function testListUserModulesDoesNotListModulesFromApiNotFoundInDatabase()
     {
-        $name = 'foo';
-
-        $repository = new stdClass();
-        $repository->fork = false;
-        $repository->permissions = new stdClass();
-        $repository->permissions->push = true;
-        $repository->name = $name;
+        $repository = $this->repository();
 
         $moduleMapper = $this->getMockBuilder(Mapper\Module::class)->getMock();
 
         $moduleMapper
             ->expects($this->once())
-            ->method('findByName')
-            ->with($this->equalTo($name))
+            ->method('findByUrl')
+            ->with($this->equalTo($repository->html_url))
             ->willReturn(false)
         ;