This repository has been archived by the owner on Jan 30, 2020. It is now read-only.
Add helper trait to provide type-hinting for zend-view #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
froschdesign
suggested changes
Sep 5, 2018
src/View/HelperTrait.php
Outdated
| * @example @var \Zend\View\Renderer\PhpRenderer|\Zend\Form\View\HelperTrait $this | ||
| * | ||
| * @method string|Form form(FormInterface $form = null) | ||
| * @method string|FormButton formButton(ElementInterface $element = null, $buttonContent = null) |
There was a problem hiding this comment.
We can add also the data types. See my comment here: zendframework/zend-i18n#102 (comment)
|
The usage of this trait must be explained in the documentation. |
|
Btw. Please use the |
thexpand
force-pushed
the
view-helper-trait
branch
from
8b0da6e
to
ccee193
Compare
Previously it was wrongly placed in the src (main directory) of the component.
… in order to overcome the 120 characters limit The comment has been copied from the PhpRenderer in the zend-view component.
thexpand
force-pushed
the
view-helper-trait
branch
from
ccee193
to
a12f676
Compare
…amework components
|
@froschdesign |
|
@thexpand |
froschdesign
reviewed
Sep 5, 2018
weierophinney
added a commit
that referenced
this pull request
Dec 11, 2018
Add helper trait to provide type-hinting for zend-view
weierophinney
added a commit
that referenced
this pull request
Dec 11, 2018
weierophinney
added a commit
that referenced
this pull request
Dec 11, 2018
|
Thanks, @thexpand! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In favor of the following proposal:
zendframework/zend-view#102