Skip to content
This repository has been archived by the owner on Jan 29, 2020. It is now read-only.

Add helper trait to provide type-hinting for zend-view #22

Merged
merged 7 commits into from
Oct 19, 2019

Conversation

thexpand
Copy link
Contributor

In favor of the following proposal:
zendframework/zend-view#102

@thexpand
Copy link
Contributor Author

@froschdesign
I'm not sure about this one, because there is already a doc-block @method in Zend\View\Renderer\PhpRenderer. Take a look:
https://github.com/zendframework/zend-view/blob/master/src/Renderer/PhpRenderer.php#L45

src/View/HelperTrait.php Outdated Show resolved Hide resolved
src/View/HelperTrait.php Outdated Show resolved Hide resolved
src/View/HelperTrait.php Outdated Show resolved Hide resolved
src/View/HelperTrait.php Outdated Show resolved Hide resolved
@froschdesign
Copy link
Member

The usage of this trait must be explained in the documentation.

@froschdesign
Copy link
Member

@thexpand thexpand changed the base branch from master to develop September 5, 2018 08:38
@thexpand
Copy link
Contributor Author

thexpand commented Sep 5, 2018

@froschdesign
I suggest adding the docs as a sub-section of the main section View Helper.
Maybe at the bottom?
See more about the naming in my comment here: zendframework/zend-i18n#102 (comment)
Here's a link to the main section in the docs: https://docs.zendframework.com/zend-mvc-plugin-flashmessenger/flash-messenger-view-helper/

@froschdesign
Copy link
Member

@thexpand

Maybe at the bottom?

For this single page is bottom okay.

@thexpand
Copy link
Contributor Author

@froschdesign
I've placed the docs at the bottom, without block quotes, in contrast to the other PRs (zendframework/zend-i18n#102, zendframework/zend-form#217)

michalbundyra added a commit that referenced this pull request Oct 19, 2019
Add helper trait to provide type-hinting for zend-view
michalbundyra added a commit that referenced this pull request Oct 19, 2019
michalbundyra added a commit that referenced this pull request Oct 19, 2019
@michalbundyra michalbundyra merged commit a60436e into zendframework:develop Oct 19, 2019
@michalbundyra
Copy link
Member

Thanks, @thexpand!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants