This repository has been archived by the owner on Jan 30, 2020. It is now read-only.
Add Module::init to register the TranslatorPluginManager with the ServiceListener #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…viceListener We need to register the TranslatorPluginManager with the ServiceListener, to allow modules and application configuration to provide additional plugin configuration. Since the ServiceListener is configured before modules are loaded, options for configuring it are limited. Adding delegator factories is out of the question, as that would require altering the application default services configuration, which is non-trivial. While this approach is slightly brittle -- if any modules are registered prior to it that have translator plugin configuration, that configuration will be ignored -- the goal is to have components registered before modules, which has some reasonable certainty of ensuring that the init() is called before any configuration is provided.
weierophinney
added a commit
that referenced
this pull request
Mar 30, 2016
weierophinney
added a commit
that referenced
this pull request
Mar 30, 2016
weierophinney
added a commit
that referenced
this pull request
Mar 30, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to register the
TranslatorPluginManagerwith theServiceListener, to allow modules and application configuration to provide additional plugin configuration.Since the
ServiceListeneris configured before modules are loaded, options for configuring it are limited. Adding delegator factories is out of the question, as that would require altering the application default services configuration, which is non-trivial.While this approach is slightly brittle — if any modules are registered prior to it that have translator plugin configuration, that configuration will be ignored — the goal is to have components registered before modules, which has some reasonable certainty of ensuring that the
init()is called before any configuration is provided.