Skip to content
This repository has been archived by the owner on Jan 30, 2020. It is now read-only.

Add Module::init to register the TranslatorPluginManager with the ServiceListener #41

Commits on Mar 30, 2016

  1. Add Module::init to register the TranslatorPluginManager with the Ser…

    …viceListener
    
    We need to register the TranslatorPluginManager with the
    ServiceListener, to allow modules and application configuration to
    provide additional plugin configuration.
    
    Since the ServiceListener is configured before modules are loaded,
    options for configuring it are limited. Adding delegator factories is
    out of the question, as that would require altering the application
    default services configuration, which is non-trivial.
    
    While this approach is slightly brittle -- if any modules are registered
    prior to it that have translator plugin configuration, that
    configuration will be ignored -- the goal is to have components
    registered before modules, which has some reasonable certainty of
    ensuring that the init() is called before any configuration is provided.
    weierophinney committed Mar 30, 2016
    Configuration menu
    Copy the full SHA
    c06d6d9 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8f3dae8 View commit details
    Browse the repository at this point in the history