-
Notifications
You must be signed in to change notification settings - Fork 50
Conversation
@@ -117,7 +117,7 @@ public function clearDefaultValidatorChain() | |||
public function setInputFilterManager(InputFilterPluginManager $inputFilterManager) | |||
{ | |||
$this->inputFilterManager = $inputFilterManager; | |||
$serviceLocator = $this->inputFilterManager->getServiceLocator(); | |||
$serviceLocator = $this->inputFilterManager; | |||
if ($serviceLocator && $serviceLocator instanceof ServiceLocatorInterface) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this check required?
Since this PR is similar to the rest of SMv3 PRs I think we should release a beta version of SMv3. Following SMv3 betas should be backward compatible. /cc @weierophinney |
I plan to tag v2.7.0 and v3 of the SM early next week, add we've finished
|
Sincerely I don't like nothing raise dependencies from 2.5 to 2.7 like has been do with stdlib.
|
'inputfilter' => InputFilter::class, | ||
'collection' => CollectionInputFilter::class, | ||
]; | ||
|
||
protected $factories = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a docblock or inheritdoc
I think your max nesting error is caused by https://github.com/zendframework/zend-inputfilter/blob/develop/src/Factory.php#L316 - calling get() is returning an existing instance. The following does the trick for me:
|
Scratch that - |
Changed $shareByDefault to $sharedByDefault
Made initialiser v2-v3 compatible
zf3 zf2 compatibility
ping @ezimuel
Work in progress