This repository has been archived by the owner on Jan 30, 2020. It is now read-only.
Finalize zend-servicemanager forwards-compatibility changes #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ServiceManager v2-v3 compatibility
- to ensure no regressions between PHP versions as well.
- ensure compat with both PHP 5.5+ and 7.0+ - Use `^2.6` (no maintenance version), as we don't need to get more specific at this time. - remove empty line at end of file
- Created a ternary from the original if/else, making the logic more compact. - Added the method docblock.
- Move v2 checks into v2-specific methods of abstract factory. - Use provided `$services` argument when lazy-instantiating filter and validator plugin managers. - For abstract factory tests, vary methods tested based on service manager version.
- Renamed `MigrationTest` to `InputFilterPluginManagerCompatibilityTest` (consistency with other components, and this is specifically for testing migration of the plugin manager). - Added tests to validate that the `InputFilterPluginManager` accepts no arguments and/or a `ConfigInterface` argument to the constructor when using zend-servicemanager v2. - Updated the `InputFilterPluginManager` constructor to mirror that of the 2.7 and 3.0 series of zend-servicemanager; it also populates the initializers prior to calling the parent constructor, allowing overriding.
From what I can tell, it was added for purposes of testing; I updated the test to use `assertAttributeSame`, varying the property to test against based on SM version.
weierophinney
added a commit
that referenced
this pull request
Feb 18, 2016
stefanotorresi
added a commit
to juriansluiman/Soflomo-Purifier
that referenced
this pull request
Mar 10, 2016
zendframework/zend-inputfilter#96 introduced a signature change in `InputFilterPluginManager::populateFactories()`
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds off of #86 and #95, with the following changes:
^2.6versions of zend-filter, zend-validator (no need to be more specific)InputFilterPluginManagerconstructor is backwards compatible with zend-servicemanager v2.A few other minor refactors were made for consistency with other components and/or to clarify context.