This repository has been archived by the owner on May 16, 2018. It is now read-only.
Zend_Console_Getopt: Missing required parameter consumes next option as its parameter value #454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -730,6 +730,33 @@ public function parse() | |||
| $this->_parsed = true; | |||
| return $this; | |||
| } | |||
|
|
|||
| public function checkRequiredArguments(){ | |||
There was a problem hiding this comment.
Please check the http://framework.zend.com/manual/1.12/en/coding-standard.coding-style.html
- newline before method opening curly brace
- space after if
- space before statement opening curly brace
- ...
|
@a-lucas |
|
@froschdesign |
|
@froschdesign I've just now processed his CLA; all set to merge. |
froschdesign
added a commit
that referenced
this pull request
Nov 13, 2014
Zend_Console_Getopt: Missing required parameter consumes next option as its parameter value
|
@a-lucas |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello here,
Following up on bug #377 (comment) ,
I created an easy fix for the moment.
I wanted to make the function checkRequiredArguments private, and automatically call it at the end of teh parse() function, but this breaks few tests because these tests assume a required value can be null.
2 tests are added :
testVerifyRequiredArgument() test the public function verifyRequiredArguments()
and testEmptyRequiredOption() shows the correct behavior.