Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2407 - PHP 8.3 support #2408

Merged
merged 95 commits into from
Oct 29, 2023
Merged

#2407 - PHP 8.3 support #2408

merged 95 commits into from
Oct 29, 2023

Conversation

Jeckerson
Copy link
Member

@Jeckerson Jeckerson commented Aug 28, 2023 •
edited
Loading

Hello!

  • Type: new feature

In raising this pull request, I confirm the following:

  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I updated the CHANGELOG

Thanks

@Jeckerson Jeckerson added enhancement nfr New Feature Request labels Aug 28, 2023
@Jeckerson Jeckerson self-assigned this Aug 28, 2023
@codecov
Copy link

codecov bot commented Aug 28, 2023 •
edited
Loading

Codecov Report

Merging #2408 (5b8e2b1) into development (90fbe76) will decrease coverage by 0.78%.
The diff coverage is 7.32%.

@@               Coverage Diff                @@
##             development   #2408      +/-   ##
================================================
- Coverage           7.00%   6.23%   -0.78%     
+ Complexity          8632    8146     -486     
================================================
  Files                343     313      -30     
  Lines              23228   22068    -1160     
================================================
- Hits                1628    1376     -252     
+ Misses             21600   20692     -908

@Jeckerson Jeckerson linked an issue Sep 13, 2023 that may be closed by this pull request
PHP 8.3 support #2407
Closed
@remicollet remicollet mentioned this pull request Oct 26, 2023
Merged
@sonarcloud
Copy link

sonarcloud bot commented Oct 29, 2023 •
edited
Loading

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 402 Code Smells

No Coverage information No Coverage information
2.9% 2.9% Duplication

@Jeckerson Jeckerson marked this pull request as ready for review October 29, 2023 20:43
@Jeckerson Jeckerson merged commit 6e15887 into development Oct 29, 2023
45 of 46 checks passed
@Jeckerson Jeckerson deleted the #2407-php8.3 branch October 29, 2023 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niden niden niden approved these changes

Assignees

@Jeckerson Jeckerson

Labels
enhancement nfr New Feature Request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PHP 8.3 support
2 participants
@Jeckerson @niden