Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fast_add_function removed in 8.3 #2418

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

remicollet
Copy link
Contributor

From UPGRADING.INTERNALS

* The fast_add_function() has been removed, use add_function() that will
  call the static inline add_function_fast() instead.

This simple change allow to build Phalcon 5.4 against 8.3.0RC5 (but not tested)

@remicollet
Copy link
Contributor Author

Already in PR #2408

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 4 Security Hotspots
Code Smell A 12 Code Smells

No Coverage information No Coverage information
5.0% 5.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Merging #2418 (29b44b4) into development (6773f19) will not change coverage.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             development   #2418   +/-   ##
=============================================
  Coverage           7.00%   7.00%           
  Complexity          8632    8632           
=============================================
  Files                343     343           
  Lines              23228   23228           
=============================================
  Hits                1628    1628           
  Misses             21600   21600           

@Jeckerson Jeckerson merged commit 90fbe76 into zephir-lang:development Oct 26, 2023
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants