nrfx: hal: auxpll: add additional APIs #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anangl
approved these changes
May 14, 2024
nrfx/hal/nrf_auxpll.h
Outdated
| * @param dither_off Turn off dither in sigma delta modulator. | ||
| * @param range Loop divider base settings. | ||
| */ | ||
| #define AUXPLL_CFGSTATIC_INIT(out_drive, constant_i, sdm_off, dither_off, range) \ |
There was a problem hiding this comment.
nit: perhaps it would be good to use here parameter names matching the corresponding fields in nrf_auxpll_config_t
gmarull
force-pushed
the
auxpll-additions
branch
3 times, most recently
from
e8f3820
to
e238659
Compare
anangl
reviewed
May 27, 2024
nrfx/hal/nrf_auxpll.h
Outdated
| * @param dither_off Turn off dither in sigma delta modulator. | ||
| * @param range Loop divider base settings. | ||
| */ | ||
| #define AUXPLL_CFGSTATIC_RAW_INIT(out_drive, constant_i, sdm_off, dither_off, range) \ |
There was a problem hiding this comment.
Wouldn't it make sense to use this macro inside nrf_auxpll_config_set()?
anangl
requested changes
May 27, 2024
nrfx/hal/nrf_auxpll.h
Outdated
| * @param dither_off Turn off dither in sigma delta modulator. | ||
| * @param range Loop divider base settings. | ||
| */ | ||
| #define AUXPLL_CFGSTATIC_RAW_INIT(out_drive, constant_i, sdm_off, dither_off, range) \ |
There was a problem hiding this comment.
This macro name should be prefixed with NRF_.
Add some additional APIs for AUXPLL that are needed/useful in the Zephyr context. Signed-off-by: Gerard Marull-Paretas <gerard@teslabs.com>
|
RAW accessor/initializer moved to #185 |
anangl
approved these changes
May 28, 2024
masz-nordic
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some additional APIs for AUXPLL that are needed/useful in the Zephyr context.