Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drivers: gpio: sch: implementation does not configure interrupt level/edge #12763

Closed
pabigot opened this issue Jan 26, 2019 · 0 comments
Closed
Assignees
Labels
area: GPIO bug The issue is a bug, or the PR is fixing a bug priority: medium Medium impact/importance bug

Comments

@pabigot
Copy link
Collaborator

pabigot commented Jan 26, 2019

gpio_sch.c configures for interrupts but does not inspect the trigger type (GPIO_INT_LEVEL vs GPIO_INT_EDGE). It should do so and should diagnose if one of those triggers is not supported.

As implemented the driver will behave correctly only for level-triggered interrupts (GPIO_INT_EDGE is the non-default configuration).

@pabigot pabigot added bug The issue is a bug, or the PR is fixing a bug area: GPIO labels Jan 26, 2019
@galak galak added the priority: medium Medium impact/importance bug label Jan 29, 2019
dcpleung added a commit to dcpleung/zephyr that referenced this issue Feb 5, 2019
The GPIO controller only supports edge triggering according to
the descriptions of the associated registers. So errors out
when level trigger is requested. Also adds the option to do
double edges triggering as the controller supports this.

Fixes zephyrproject-rtos#12763

Signed-off-by: Daniel Leung <daniel.leung@intel.com>
galak pushed a commit that referenced this issue Feb 7, 2019
The GPIO controller only supports edge triggering according to
the descriptions of the associated registers. So errors out
when level trigger is requested. Also adds the option to do
double edges triggering as the controller supports this.

Fixes #12763

Signed-off-by: Daniel Leung <daniel.leung@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: GPIO bug The issue is a bug, or the PR is fixing a bug priority: medium Medium impact/importance bug
Projects
None yet
Development

No branches or pull requests

3 participants