gpio: gpio_sch: error when configure for level triggers #13076
Conversation
The GPIO controller only supports edge triggering according to the descriptions of the associated registers. So errors out when level trigger is requested. Also adds the option to do double edges triggering as the controller supports this. Fixes zephyrproject-rtos#12763 Signed-off-by: Daniel Leung <daniel.leung@intel.com>
Codecov Report
@@ Coverage Diff @@
## master #13076 +/- ##
=======================================
Coverage 48.63% 48.63%
=======================================
Files 313 313
Lines 46436 46436
Branches 10710 10710
=======================================
Hits 22585 22585
Misses 19395 19395
Partials 4456 4456Continue to review full report at Codecov.
|
| @@ -128,6 +131,12 @@ static int gpio_sch_config(struct device *dev, | |||
| { | |||
| const struct gpio_sch_config *info = dev->config->config_info; | |||
|
|
|||
| /* Do some sanity check first */ | |||
| if (flags & (GPIO_INT | GPIO_INT_LEVEL)) { | |||
There was a problem hiding this comment.
@dcpleung @galak @tbursztyka I'm reasonably sure this doesn't do what you think it does, because GPIO_INT_LEVEL is zero. So I'm pretty sure you've made it so that you're exiting with -EINVAL if interrupts are enabled.
There were commits in #11880 which addressed several similar bugs (esp32 in particular is also broken).
There was a problem hiding this comment.
Thanks for letting me know. I have submitted #13143 to fix this.
The GPIO controller only supports edge triggering according to
the descriptions of the associated registers. So errors out
when level trigger is requested. Also adds the option to do
double edges triggering as the controller supports this.
Fixes #12763
Signed-off-by: Daniel Leung daniel.leung@intel.com