Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TOPIC-GPIO] gpi_api_1pin test failures #19692

Closed
pabigot opened this issue Oct 8, 2019 · 2 comments
Closed

[TOPIC-GPIO] gpi_api_1pin test failures #19692

pabigot opened this issue Oct 8, 2019 · 2 comments
Assignees
Labels
area: GPIO bug The issue is a bug, or the PR is fixing a bug priority: medium Medium impact/importance bug

Comments

@pabigot
Copy link
Collaborator

pabigot commented Oct 8, 2019

* `gpio_api_1pin`: Failed all tested boards so far. Investigating this is my next task

There is one issue I've noticed just recently that may cause 1 pin testcase to fail. The testcases testing the new port functions attempt to verify that the driver doesn't change other pins than the one that was requested. But the test doesn't take into account that the LED0 pin it's using for testing may be on the same port as UART used for the console. When reading port values the pin serving as UART RX will introduce inconsistency to the port value the testcase is expecting. If you see failures in any of test_gpio_port_* tests please ignore it for now. I'll provide a fix.

Originally posted by @mnkp in #19579 (comment)

@pabigot
Copy link
Collaborator Author

pabigot commented Oct 8, 2019

Added issue for visibility.

#19379 for SX1509B also fails all test_gpio_port_set_* cases. This case is a little more subtle and interesting: the nrf52_pca20020 Thingy:52 board has RGB lightwell LEDs that are very bright, and RGB sense LEDs on the bottom of the board. The device powers up with GPIOs set with input enabled. When the test green LED is illuminated the sense green LED goes high, so two pins on the port change in parallel.

FAIL - test_gpio_port_set_masked_get_raw
FAIL - test_gpio_port_set_masked_get
FAIL - test_gpio_port_set_masked_get_active_high
FAIL - test_gpio_port_set_masked_get_active_low
FAIL - test_gpio_port_set_bits_clear_bits_raw
FAIL - test_gpio_port_set_bits_clear_bits
FAIL - test_gpio_port_set_clr_bits_raw
FAIL - test_gpio_port_set_clr_bits
FAIL - test_gpio_port_toggle

@pabigot pabigot added bug The issue is a bug, or the PR is fixing a bug priority: medium Medium impact/importance bug labels Oct 10, 2019
mnkp added a commit to mnkp/zephyr that referenced this issue Oct 12, 2019
Keep promise of testing 1 pin only, don't attempt to test other pins
when verifying gpio_port_* API functions. Use BIT macro to create a bit
mask.

Fixes: zephyrproject-rtos#19692

Signed-off-by: Piotr Mienkowski <piotr.mienkowski@gmail.com>
MaureenHelm pushed a commit that referenced this issue Oct 16, 2019
Keep promise of testing 1 pin only, don't attempt to test other pins
when verifying gpio_port_* API functions. Use BIT macro to create a bit
mask.

Fixes: #19692

Signed-off-by: Piotr Mienkowski <piotr.mienkowski@gmail.com>
@pabigot
Copy link
Collaborator Author

pabigot commented Oct 22, 2019

Should be closed by #19782

@pabigot pabigot closed this as completed Oct 22, 2019
galak pushed a commit that referenced this issue Oct 25, 2019
Keep promise of testing 1 pin only, don't attempt to test other pins
when verifying gpio_port_* API functions. Use BIT macro to create a bit
mask.

Fixes: #19692

Signed-off-by: Piotr Mienkowski <piotr.mienkowski@gmail.com>
galak pushed a commit to galak/zephyr that referenced this issue Nov 13, 2019
Keep promise of testing 1 pin only, don't attempt to test other pins
when verifying gpio_port_* API functions. Use BIT macro to create a bit
mask.

Fixes: zephyrproject-rtos#19692

Signed-off-by: Piotr Mienkowski <piotr.mienkowski@gmail.com>
galak pushed a commit to galak/zephyr that referenced this issue Jan 15, 2020
Keep promise of testing 1 pin only, don't attempt to test other pins
when verifying gpio_port_* API functions. Use BIT macro to create a bit
mask.

Fixes: zephyrproject-rtos#19692

Signed-off-by: Piotr Mienkowski <piotr.mienkowski@gmail.com>
galak pushed a commit to galak/zephyr that referenced this issue Jan 15, 2020
Keep promise of testing 1 pin only, don't attempt to test other pins
when verifying gpio_port_* API functions. Use BIT macro to create a bit
mask.

Fixes: zephyrproject-rtos#19692

Signed-off-by: Piotr Mienkowski <piotr.mienkowski@gmail.com>
pabigot pushed a commit to pabigot/zephyr that referenced this issue Jan 26, 2020
Keep promise of testing 1 pin only, don't attempt to test other pins
when verifying gpio_port_* API functions. Use BIT macro to create a bit
mask.

Fixes: zephyrproject-rtos#19692

Signed-off-by: Piotr Mienkowski <piotr.mienkowski@gmail.com>
pabigot pushed a commit to pabigot/zephyr that referenced this issue Jan 26, 2020
Keep promise of testing 1 pin only, don't attempt to test other pins
when verifying gpio_port_* API functions. Use BIT macro to create a bit
mask.

Fixes: zephyrproject-rtos#19692

Signed-off-by: Piotr Mienkowski <piotr.mienkowski@gmail.com>
pabigot pushed a commit to pabigot/zephyr that referenced this issue Jan 28, 2020
Keep promise of testing 1 pin only, don't attempt to test other pins
when verifying gpio_port_* API functions. Use BIT macro to create a bit
mask.

Fixes: zephyrproject-rtos#19692

Signed-off-by: Piotr Mienkowski <piotr.mienkowski@gmail.com>
pabigot pushed a commit to pabigot/zephyr that referenced this issue Jan 29, 2020
Keep promise of testing 1 pin only, don't attempt to test other pins
when verifying gpio_port_* API functions. Use BIT macro to create a bit
mask.

Fixes: zephyrproject-rtos#19692

Signed-off-by: Piotr Mienkowski <piotr.mienkowski@gmail.com>
pabigot pushed a commit to pabigot/zephyr that referenced this issue Jan 29, 2020
Keep promise of testing 1 pin only, don't attempt to test other pins
when verifying gpio_port_* API functions. Use BIT macro to create a bit
mask.

Fixes: zephyrproject-rtos#19692

Signed-off-by: Piotr Mienkowski <piotr.mienkowski@gmail.com>
pabigot pushed a commit to pabigot/zephyr that referenced this issue Jan 29, 2020
Keep promise of testing 1 pin only, don't attempt to test other pins
when verifying gpio_port_* API functions. Use BIT macro to create a bit
mask.

Fixes: zephyrproject-rtos#19692

Signed-off-by: Piotr Mienkowski <piotr.mienkowski@gmail.com>
pabigot pushed a commit to pabigot/zephyr that referenced this issue Jan 29, 2020
Keep promise of testing 1 pin only, don't attempt to test other pins
when verifying gpio_port_* API functions. Use BIT macro to create a bit
mask.

Fixes: zephyrproject-rtos#19692

Signed-off-by: Piotr Mienkowski <piotr.mienkowski@gmail.com>
pabigot pushed a commit to pabigot/zephyr that referenced this issue Jan 30, 2020
Keep promise of testing 1 pin only, don't attempt to test other pins
when verifying gpio_port_* API functions. Use BIT macro to create a bit
mask.

Fixes: zephyrproject-rtos#19692

Signed-off-by: Piotr Mienkowski <piotr.mienkowski@gmail.com>
pabigot pushed a commit to pabigot/zephyr that referenced this issue Feb 2, 2020
Keep promise of testing 1 pin only, don't attempt to test other pins
when verifying gpio_port_* API functions. Use BIT macro to create a bit
mask.

Fixes: zephyrproject-rtos#19692

Signed-off-by: Piotr Mienkowski <piotr.mienkowski@gmail.com>
pabigot pushed a commit that referenced this issue Feb 2, 2020
Keep promise of testing 1 pin only, don't attempt to test other pins
when verifying gpio_port_* API functions. Use BIT macro to create a bit
mask.

Fixes: #19692

Signed-off-by: Piotr Mienkowski <piotr.mienkowski@gmail.com>
pabigot pushed a commit to pabigot/zephyr that referenced this issue Feb 4, 2020
Keep promise of testing 1 pin only, don't attempt to test other pins
when verifying gpio_port_* API functions. Use BIT macro to create a bit
mask.

Fixes: zephyrproject-rtos#19692

Signed-off-by: Piotr Mienkowski <piotr.mienkowski@gmail.com>
pabigot pushed a commit that referenced this issue Feb 5, 2020
Keep promise of testing 1 pin only, don't attempt to test other pins
when verifying gpio_port_* API functions. Use BIT macro to create a bit
mask.

Fixes: #19692

Signed-off-by: Piotr Mienkowski <piotr.mienkowski@gmail.com>
pabigot pushed a commit that referenced this issue Feb 5, 2020
Keep promise of testing 1 pin only, don't attempt to test other pins
when verifying gpio_port_* API functions. Use BIT macro to create a bit
mask.

Fixes: #19692

Signed-off-by: Piotr Mienkowski <piotr.mienkowski@gmail.com>
carlescufi pushed a commit that referenced this issue Feb 5, 2020
Keep promise of testing 1 pin only, don't attempt to test other pins
when verifying gpio_port_* API functions. Use BIT macro to create a bit
mask.

Fixes: #19692

Signed-off-by: Piotr Mienkowski <piotr.mienkowski@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: GPIO bug The issue is a bug, or the PR is fixing a bug priority: medium Medium impact/importance bug
Projects
None yet
Development

No branches or pull requests

2 participants