-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TOPIC-GPIO] drivers: gpio_sx1509b: update to use new GPIO API #19379
Merged
MaureenHelm
merged 1 commit into
zephyrproject-rtos:topic-gpio
from
pabigot:gpio/sx1509b
Oct 14, 2019
Merged
[TOPIC-GPIO] drivers: gpio_sx1509b: update to use new GPIO API #19379
MaureenHelm
merged 1 commit into
zephyrproject-rtos:topic-gpio
from
pabigot:gpio/sx1509b
Oct 14, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pabigot
requested review from
carlescufi,
ioannisg,
lemrey,
nashif and
SebastianBoe
as code owners
September 25, 2019 15:49
pabigot
force-pushed
the
gpio/sx1509b
branch
from
September 25, 2019 15:52
947b247
to
0d62ac1
Compare
zephyrbot
added
area: Boards
area: Tests
Issues related to a particular existing or missing test
area: Build System
labels
Sep 25, 2019
All checks are passing now. checkpatch (informational only, not a failure)
Tip: The bot edits this comment instead of posting a new one, so you can check the comment's history to see earlier messages. |
galak
approved these changes
Oct 4, 2019
pabigot
changed the title
drivers: gpio_sx1509b: update to use new GPIO API
[TOPIC-GPIO] drivers: gpio_sx1509b: update to use new GPIO API
Oct 8, 2019
mnkp
reviewed
Oct 8, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with minor comments.
pabigot
force-pushed
the
gpio/sx1509b
branch
2 times, most recently
from
October 9, 2019 15:13
cd222e8
to
3106384
Compare
@mnkp all requests should be addressed ; see the last force-push for diffs. |
mnkp
approved these changes
Oct 9, 2019
Update driver code and board files to use new GPIO configuration flags such as GPIO_ACTIVE_LOW. Also add implementation of new port_* driver API. Tested on external SX1509B breakout board and Thingy:52. Signed-off-by: Peter Bigot <peter.bigot@nordicsemi.no>
MaureenHelm
approved these changes
Oct 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area: Boards
area: Build System
area: GPIO
area: Tests
Issues related to a particular existing or missing test
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert the SX1509B driver to the new API.
This also includes general cleanup to the driver as it's based on work that had been done for #11880.
This driver does not pass
gpio_api_1pin
. See #19692.