zio: Introduce ft5336 touch sensor driver and integrate into LittlevGL #16119

MaureenHelm · 2019-05-13T20:32:36Z

Depends on #14008

Implements the zio interface for the ft5336 capacitive touch sensor on mimxrt10{50,60}_evk boards
Adds support in LittlevGL to use the zio interface to read touch sensor input data

teburd · 2019-05-13T22:13:25Z

First of all, very cool that you made this, this is as far from my use case I was envisioning as I could imagine and yet I think it still works quite well here. I'm interested to know your thoughts on where to proceed next with this interface given this unique and fun use case

ulfalizer · 2019-05-16T00:10:39Z

lib/gui/lvgl/Kconfig

+
+config LVGL_INPUT_POINTER_DEV_NAME
+	string "Input pointer device name"
+	default "INPUT"


Maybe a depends on LVGL_INPUT_POINTER would make sense here, so that this symbol doesn't show up in the menu when LVGL_INPUT_POINTER is disabled.

microbuilder · 2019-05-22T21:43:21Z

drivers/zio/ft5336/ft5336.c

+		u8_t yl;
+		u8_t reserved[2];
+	} touch[MAX_TOUCHES];
+} __packed;


How do we know which of the 5 possible touch point events are valid? Is it worth having some sort of .valid flag to indicate that a particular record is valid, or should we be checking for 0 values to know if touch[x] contains useful data (one finger used, three fingers, etc.)?

microbuilder · 2019-05-22T21:49:10Z

drivers/zio/ft5336/ft5336.c

+static const struct zio_dev_api ft5336_driver_api = {
+	.set_attr = NULL,
+	.get_attr = NULL,
+	.get_attrs = NULL,


Some sort of attribute may be useful to have here as a reference, even if it's something simple like exposing the driver version number. In my opinion, exposing a driver version in a standard manner might even be worth considering as a mandatory part of zio since it has little overall cost, but is a useful datapoint when debugging remote devices in the field, or reporting device information.

Alternatively, perhaps the Operation Mode of the FT5336 could be exposed as an attribute (Active, Monitor or Hibernate looking at the DS)?

Where did you find the DS??? I couldn't find it, so I used the MCUXpresso SDK driver as a reference.

https://www.crystalfontz.com/controllers/FocalTech/FT5336GQQ/

MaureenHelm · 2019-05-23T13:31:15Z

Rebased now that #14008 and #16262 have been merged, and added rt1064 support.

zephyrbot · 2019-05-23T13:46:13Z

All checks are passing now.

Review history of this comment for details about previous failed status.
Note that some checks might have not completed yet.

teburd

This looks like a nice beginning

teburd · 2019-06-18T22:11:06Z

include/drivers/zio/ft5336.h

+#include <zio.h>
+
+/* channel type(s) */
+#define FT5336_COORD_TYPE	(ZIO_CHAN_TYPES + 1)


Are these ever manipulated or retrieved separately?

teburd · 2019-06-18T22:14:04Z

drivers/zio/ft5336/ft5336.c

+	const struct ft5336_config *config = dev->config->config_info;
+	struct ft5336_data *data = dev->driver_data;
+	struct ft5336_raw raw;
+	struct ft5336_datum datum;


Since we're doing some work to reformat things anyways, maybe its worthwhile just directly converting this to a stream of input event structs, if its only ever for littlevgl, then perhaps just directly converting to littlevgl events could be a simplification

Adds device tree bindings and nodes for the ft5336 capacitive touch sensor to the mimxrt10{50,60,64}_evk boards. Signed-off-by: Maureen Helm <maureen.helm@nxp.com>

Introduces a new zio driver for the ft5336 capacitive touch sensor. Signed-off-by: Maureen Helm <maureen.helm@nxp.com>

Adds support for LittlevGL input devices using the new zio interface. This should ultimately be independent of the specific touch controller, however it is currently tied to the ft5336 due to the lack of an abstracted touch sensor data type. We also have not implemented gpio interrupts in the ft5336 driver and therefore rely on manual triggering, making the touch input appear a bit laggy in the gui. Signed-off-by: Maureen Helm <maureen.helm@nxp.com>

Configures LittlevGL to use the ft5336 capacitive touch sensor input by default on the mimxrt10{50,60,64}_evk boards. Signed-off-by: Maureen Helm <maureen.helm@nxp.com>

Enables the touch sensor input and adds a keyboard object to the LittlevGL sample application. This is a hack, do not merge! Signed-off-by: Maureen Helm <maureen.helm@nxp.com>

Prior to this patch, zio only supported u32_t variants. Add support for wrapping and unwrapping u8_t variants so the ft5336 driver can implement a new u8_t attribute. Signed-off-by: Maureen Helm <maureen.helm@nxp.com>

Adds a read/write device attribute to the ft5336 zio driver to runtime configure the number of touches to push to the fifo. The ft5336 hardware can support up to five simultaneous touches, but some applications like LittlevGL only use a single touch. Signed-off-by: Maureen Helm <maureen.helm@nxp.com>

LittlevGL doesn't suport multitouch inputs, so use the zio attribute setter interface to configure the ft5336 driver to only push single touches to the zio fifo. Signed-off-by: Maureen Helm <maureen.helm@nxp.com>

MaureenHelm · 2019-07-09T21:17:54Z

Rebased to latest topic-sensors branch now that #16266 has been merged. Adds three new commits to implement getting and setting a device attribute.

vanwinkeljan · 2019-07-25T18:49:28Z

@MaureenHelm just a heads up but I have an outstanding PR (#17629) to introduce LVGL V6.
As the new version has multiple display support it break API backwards compatibility with V5.

vanwinkeljan · 2019-07-25T18:57:39Z

samples/gui/lvgl/src/main.c

@@ -37,6 +37,32 @@ void main(void)
 	count_label = lv_label_create(lv_scr_act(), NULL);
 	lv_obj_align(count_label, NULL, LV_ALIGN_IN_BOTTOM_MID, 0, 0);

+	/*Create styles for the keyboard*/


In case it is of any use I have a sample floating around that uses GPIO pins to control some switches maybe this could be extended to allow controle through the touch screen.

carlescufi · 2019-08-27T16:28:29Z

@MaureenHelm since zio has now been replaced with rtio, this PR needs rebasing against the new API.

MaureenHelm added area: Sensors Sensors area: API Changes to public APIs labels May 13, 2019

MaureenHelm requested a review from microbuilder May 13, 2019 20:32

ulfalizer reviewed May 16, 2019

View reviewed changes

MaureenHelm mentioned this pull request May 20, 2019

boards: mimxrt1060_evk: Enable mcux lpi2c driver and pins #16262

Merged

microbuilder reviewed May 22, 2019

View reviewed changes

MaureenHelm force-pushed the zio-ft5336 branch from 510b6d3 to a0d0510 Compare May 23, 2019 13:29

microbuilder requested a review from teburd June 18, 2019 15:19

teburd approved these changes Jun 19, 2019

View reviewed changes

MaureenHelm force-pushed the topic-sensors branch from e4bdd9c to 14b8922 Compare July 5, 2019 16:09

MaureenHelm added 8 commits July 8, 2019 16:14

dts: boards: Add ft5336 touch sensor dts bindings and nodes

f68e123

Adds device tree bindings and nodes for the ft5336 capacitive touch sensor to the mimxrt10{50,60,64}_evk boards. Signed-off-by: Maureen Helm <maureen.helm@nxp.com>

drivers: zio: Introduce ft5336 touch sensor driver

38728c4

Introduces a new zio driver for the ft5336 capacitive touch sensor. Signed-off-by: Maureen Helm <maureen.helm@nxp.com>

boards: Configure LittlevGL input defaults on mimxrt10{50,60,64}_evk

4a1e75d

Configures LittlevGL to use the ft5336 capacitive touch sensor input by default on the mimxrt10{50,60,64}_evk boards. Signed-off-by: Maureen Helm <maureen.helm@nxp.com>

samples: gui: Hack the LittlevGL sample to use touch input

84de52e

Enables the touch sensor input and adds a keyboard object to the LittlevGL sample application. This is a hack, do not merge! Signed-off-by: Maureen Helm <maureen.helm@nxp.com>

zio: Add support for wrapping/unwrapping u8_t variants

b69e342

Prior to this patch, zio only supported u32_t variants. Add support for wrapping and unwrapping u8_t variants so the ft5336 driver can implement a new u8_t attribute. Signed-off-by: Maureen Helm <maureen.helm@nxp.com>

lib: gui: Configure LittlevGL touch input driver to single touch

21e9e16

LittlevGL doesn't suport multitouch inputs, so use the zio attribute setter interface to configure the ft5336 driver to only push single touches to the zio fifo. Signed-off-by: Maureen Helm <maureen.helm@nxp.com>

MaureenHelm force-pushed the zio-ft5336 branch from a0d0510 to 21e9e16 Compare July 9, 2019 21:15

zephyrbot added area: Devicetree area: Boards area: Samples Samples labels Jul 9, 2019

vanwinkeljan self-requested a review July 25, 2019 18:49

vanwinkeljan reviewed Jul 25, 2019

View reviewed changes

This was referenced Jul 31, 2019

zio: Introduce hts221 humidity sensor #17915

Closed

zio: Introduce hts221 humidity sensor #17921

Closed

mbolivar self-requested a review August 27, 2019 16:34

vanwinkeljan mentioned this pull request Sep 13, 2019

shields: add Adafruit 2.8" TFT Touch Shield v2. #19124

Merged

pavlohamov mentioned this pull request Sep 26, 2019

lvgl: input: temporarry touch implementation #19372

Closed

mbolivar removed their request for review January 13, 2020 23:24

MaureenHelm mentioned this pull request Jan 20, 2020

Introduce ft5336 touch panel driver and integrate into lvgl #22055

Merged

MaureenHelm closed this Feb 3, 2020

dleach02 deleted the zio-ft5336 branch July 17, 2024 01:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

zio: Introduce ft5336 touch sensor driver and integrate into LittlevGL #16119

zio: Introduce ft5336 touch sensor driver and integrate into LittlevGL #16119

MaureenHelm commented May 13, 2019

teburd commented May 13, 2019

ulfalizer May 16, 2019

microbuilder May 22, 2019

microbuilder May 22, 2019

MaureenHelm May 23, 2019

microbuilder May 24, 2019

MaureenHelm commented May 23, 2019

zephyrbot commented May 23, 2019 •

edited

Loading

teburd left a comment

teburd Jun 18, 2019

teburd Jun 18, 2019

MaureenHelm commented Jul 9, 2019

vanwinkeljan commented Jul 25, 2019

vanwinkeljan Jul 25, 2019

carlescufi commented Aug 27, 2019

zio: Introduce ft5336 touch sensor driver and integrate into LittlevGL #16119

zio: Introduce ft5336 touch sensor driver and integrate into LittlevGL #16119

Conversation

MaureenHelm commented May 13, 2019

teburd commented May 13, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MaureenHelm commented May 23, 2019

zephyrbot commented May 23, 2019 • edited Loading

teburd left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MaureenHelm commented Jul 9, 2019

vanwinkeljan commented Jul 25, 2019

Choose a reason for hiding this comment

carlescufi commented Aug 27, 2019

zephyrbot commented May 23, 2019 •

edited

Loading