Introduce ft5336 touch panel driver and integrate into lvgl #22055

MaureenHelm · 2020-01-20T22:15:03Z

This is another attempt to enable the touch panel driver on i.mx rt boards and integrate into LittlevGL. Unlike #16119 which uses the experimental zio interface in the topic-sensors branch, this version uses the existing kscan interface already in master.

One small change was required in the kscan api, extending row and column callback arguments from 8-bits to 32-bits.

alexanderwachter · 2020-01-21T09:08:18Z

lib/gui/lvgl/lvgl.c

+};
+
+static K_MEM_SLAB_DEFINE(kscan_slab, sizeof(struct kscan_fifo_data), 10, 4);
+static K_FIFO_DEFINE(kscan_fifo);


Why not using a k_msgq here?

no reason, thanks for the suggestion. i've updated the pr to use a msgq.

dleach02

lgtm. The API change is fairly safe.

Extends the keyboard scan callback row and column arguments from 8-bits to 32-bits to support a touch panel driver implementation. Signed-off-by: Maureen Helm <maureen.helm@nxp.com>

Adds device tree bindings for the focaltech ft5336 touch panel controller, which will be used on several i.mx rt evk boards. Moves address-cells and size-cells properties from the base kscan bindings to the specific microchip,xec bindings since they are not required for the ft5336. Signed-off-by: Maureen Helm <maureen.helm@nxp.com>

Introduces a new ft5336 touch panel driver for the keyboard scan (kscan) interface. The driver currently uses a timer to periodically poll touch data in the system work queue, but later it can be enhanced to use a gpio interrupt instead of a timer. Signed-off-by: Maureen Helm <maureen.helm@nxp.com>

MaureenHelm · 2020-01-22T19:54:31Z

rebased to pick up #22056

franciscomunoz

LGTM

vanwinkeljan

Looks like a good stop-gap solution until we have a real touch screen API, but we should make clear in the Kconfig that kscan is used for a pointer like device and not a keyboard.

vanwinkeljan · 2020-01-25T11:09:03Z

lib/gui/lvgl/Kconfig

+	help
+	  Enable keyboard scan input
+
+config LVGL_KSCAN_DEV_NAME


Wondering if LVGL_KSCAN_DEV_NAME should be renamed to LVGL_POINTER_KSCAN_DEV_NAME to make it clear that it is a pointer like input device and not a real keyboard.

vanwinkeljan · 2020-01-25T11:12:44Z

lib/gui/lvgl/Kconfig

+
+config LVGL_KSCAN_DEV_NAME
+	string "Keyboard scan input device name"
+	depends on LVGL_KSCAN


Put LVGL_KSCAN_DEV_NAME and LVGL_KSCAN_MSGQ_COUNT between if LVGL_KSCAN instead of using depends on LVGL_KSCAN

vanwinkeljan · 2020-01-25T11:28:11Z

lib/gui/lvgl/lvgl.c

+#ifdef CONFIG_LVGL_KSCAN
+K_MSGQ_DEFINE(kscan_msgq, sizeof(lv_indev_data_t),
+	      CONFIG_LVGL_KSCAN_MSGQ_COUNT, 4);
+static lv_indev_drv_t indev_drv;


No need to make this global variable, it can just be a local variable in lvgl_kscan_init as lv_indev_drv_register makes a copy of the variable.

Adds support for an optional lvgl touch input device using the zephyr keyboard scan interface. This can be used with the ft5336 touch panel driver, which returns single touch coordinates through the kscan driver callback. Signed-off-by: Maureen Helm <maureen.helm@nxp.com>

jfischer-no · 2020-01-27T16:36:34Z

samples/display/lvgl/boards/mimxrt1050_evk.conf

+# Copyright (c) 2020 NXP
+# SPDX-License-Identifier: Apache-2.0
+
+CONFIG_I2C=y


This board config files are a maintenance overhead sometimes. Why not enable it in soc/arm/nxp_imx/rt/Kconfig.defconfig.series ?

I didn't implement it originally because I was worried about complex Kconfig dependencies, but given your feedback I went ahead and did it now. Please have a look at the updated version.

jfischer-no · 2020-01-27T16:42:40Z

samples/display/lvgl/src/main.c

@@ -30,7 +31,10 @@ void main(void)
 		return;
 	}

-	hello_world_label = lv_label_create(lv_scr_act(), NULL);
+	hello_world_button = lv_btn_create(lv_scr_act(), NULL);


Let me test it on different displays, probably button could be conditional.

The button does not look good on monochrome displays because of the background gradient, I suggest to use the button only if KSCAN is enabled, e.g.:

diff --git a/samples/display/lvgl/src/main.c b/samples/display/lvgl/src/main.c index c40808258d..c566b52922 100644 --- a/samples/display/lvgl/src/main.c +++ b/samples/display/lvgl/src/main.c @@ -31,10 +31,14 @@ void main(void) return; } - hello_world_button = lv_btn_create(lv_scr_act(), NULL); - lv_obj_align(hello_world_button, NULL, LV_ALIGN_CENTER, 0, 0); + if (IS_ENABLED(CONFIG_KSCAN)) { + hello_world_button = lv_btn_create(lv_scr_act(), NULL); + lv_obj_align(hello_world_button, NULL, LV_ALIGN_CENTER, 0, 0); + hello_world_label = lv_label_create(hello_world_button, NULL); + } else { + hello_world_label = lv_label_create(lv_scr_act(), NULL); + } - hello_world_label = lv_label_create(hello_world_button, NULL); lv_label_set_text(hello_world_label, "Hello world!"); lv_obj_align(hello_world_label, NULL, LV_ALIGN_CENTER, 0, 0);

It's a bit awkward to conditionalize the sample like this. What if we instead configured monochrome displays to use the mono theme by default?

It's a bit awkward to conditionalize the sample like this.

no preprocessor macros are awkward, if (IS_ENABLED(CONFIG_OPTION)) { is fine.

What if we instead configured monochrome displays to use the mono theme by default?

yes, an option. But it looks anyway ugly on small displays, the button size does not scale, probably lv_btn_set_fit would help.

lv_btn_set_fit(hello_world_button, LV_FIT_TIGHT); did not work well, the button is still too big for a 128x64 pixel display.

I'm not fond of making the button conditional in a simple "hello world" type of example, but I don't have a 128x64 pixel display to play with making the button fit. I updated the patch to your suggestion.

Adds device tree nodes and configures Kconfig defaults for the ft5336 touch panel driver on mimxrt10{50,60,64}_evk boards. Signed-off-by: Maureen Helm <maureen.helm@nxp.com>

Enhances the lvgl sample to support an optional touch panel input on mimxrt10{50,60,64}_evk boards. Signed-off-by: Maureen Helm <maureen.helm@nxp.com>

MaureenHelm added the platform: NXP NXP label Jan 20, 2020

MaureenHelm requested review from vanwinkeljan and dleach02 January 20, 2020 22:15

MaureenHelm requested review from albertofloyd, carlescufi, franciscomunoz, galak, nashif and scottwcpg as code owners January 20, 2020 22:15

zephyrbot added area: Devicetree area: Boards area: API Changes to public APIs area: Samples Samples area: Tests Issues related to a particular existing or missing test labels Jan 20, 2020

alexanderwachter reviewed Jan 21, 2020

View reviewed changes

dleach02 approved these changes Jan 21, 2020

View reviewed changes

MaureenHelm force-pushed the kscan-touch branch from 4224336 to a0a82b8 Compare January 21, 2020 20:11

MaureenHelm added 3 commits January 22, 2020 13:52

drivers: kscan: Extend callback arguments to 32-bits

2f74082

Extends the keyboard scan callback row and column arguments from 8-bits to 32-bits to support a touch panel driver implementation. Signed-off-by: Maureen Helm <maureen.helm@nxp.com>

MaureenHelm force-pushed the kscan-touch branch from a0a82b8 to 209bf8d Compare January 22, 2020 19:53

franciscomunoz approved these changes Jan 25, 2020

View reviewed changes

vanwinkeljan requested changes Jan 25, 2020

View reviewed changes

MaureenHelm force-pushed the kscan-touch branch from 209bf8d to 751a072 Compare January 26, 2020 20:01

MaureenHelm requested review from vanwinkeljan and jfischer-no January 26, 2020 20:03

vanwinkeljan approved these changes Jan 26, 2020

View reviewed changes

jfischer-no requested changes Jan 27, 2020

View reviewed changes

boards: Configure ft5336 touch panel on i.mx rt boards

7ccea08

Adds device tree nodes and configures Kconfig defaults for the ft5336 touch panel driver on mimxrt10{50,60,64}_evk boards. Signed-off-by: Maureen Helm <maureen.helm@nxp.com>

MaureenHelm force-pushed the kscan-touch branch from 751a072 to 03dca4c Compare January 27, 2020 19:02

samples: display: Enhance lvgl sample to support touch input

1f2935f

Enhances the lvgl sample to support an optional touch panel input on mimxrt10{50,60,64}_evk boards. Signed-off-by: Maureen Helm <maureen.helm@nxp.com>

MaureenHelm force-pushed the kscan-touch branch from 03dca4c to 1f2935f Compare January 28, 2020 19:15

jfischer-no approved these changes Jan 30, 2020

View reviewed changes

jfischer-no added this to the v2.2.0 milestone Jan 31, 2020

jfischer-no mentioned this pull request Jan 31, 2020

lvgl: input: temporarry touch implementation #19372

Closed

nashif merged commit 06d17aa into zephyrproject-rtos:master Feb 1, 2020

MaureenHelm deleted the kscan-touch branch February 3, 2020 14:57

pavlohamov mentioned this pull request Feb 28, 2020

LVGL: Add native_posix input driver #22426

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Introduce ft5336 touch panel driver and integrate into lvgl #22055

Introduce ft5336 touch panel driver and integrate into lvgl #22055

MaureenHelm commented Jan 20, 2020

alexanderwachter Jan 21, 2020

MaureenHelm Jan 21, 2020

dleach02 left a comment

MaureenHelm commented Jan 22, 2020

franciscomunoz left a comment

vanwinkeljan left a comment

vanwinkeljan Jan 25, 2020

MaureenHelm Jan 26, 2020

vanwinkeljan Jan 25, 2020

MaureenHelm Jan 26, 2020

vanwinkeljan Jan 25, 2020

MaureenHelm Jan 26, 2020

jfischer-no Jan 27, 2020

MaureenHelm Jan 27, 2020

jfischer-no Jan 27, 2020

jfischer-no Jan 27, 2020

MaureenHelm Jan 28, 2020

jfischer-no Jan 28, 2020 •

edited

Loading

jfischer-no Jan 28, 2020

MaureenHelm Jan 28, 2020

Introduce ft5336 touch panel driver and integrate into lvgl #22055

Introduce ft5336 touch panel driver and integrate into lvgl #22055

Conversation

MaureenHelm commented Jan 20, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dleach02 left a comment

Choose a reason for hiding this comment

MaureenHelm commented Jan 22, 2020

franciscomunoz left a comment

Choose a reason for hiding this comment

vanwinkeljan left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jfischer-no Jan 28, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jfischer-no Jan 28, 2020 •

edited

Loading