LVGL: Add native_posix input driver #22426

pavlohamov · 2020-02-03T14:16:40Z

Implement native_posix input driver (kscan)
Support input in lvgl display sample

zephyrbot · 2020-02-03T14:20:00Z

All checks are passing now.

Tip: The bot edits this comment instead of posting a new one, so you can check the comment's history to see earlier messages.

vanwinkeljan

Some minor remarks and I also have a feeling the dts config is a bit redundant in this case

drivers/kscan/Kconfig.sdl

pavlohamov · 2020-02-11T14:13:55Z

Some minor remarks and I also have a feeling the dts config is a bit redundant in this case

Don't know why, but i thought it not gonna work without dts entry. Removed. Now style is consistent with SDL display.

jfischer-no · 2020-02-11T17:44:40Z

samples/display/lvgl/boards/native_posix.conf

@@ -2,3 +2,8 @@ CONFIG_SDL_DISPLAY=y
 CONFIG_SDL_DISPLAY_DEV_NAME="DISPLAY"
 CONFIG_SDL_DISPLAY_X_RES=320
 CONFIG_SDL_DISPLAY_Y_RES=240
+
+CONFIG_KSCAN=y


Please move it to boards/posix/native_posix/Kconfig.defconfig, it already has DISPLAY configuration there. The same for native_posix_64.conf

@jfischer-phytec-iot You mean CONFIG_KSCAN_SDL if CONFIG_KSCAN?

@aescolar Yes similar as it was done for mimxrt boards 7ccea08

@jfischer-phytec-iot Does it make sense to add

config DISPlAY default y if LVGL config KSCAN default y if LVGL

as well?

UPD: not relevant anymore

I still do not agree to add new options to samples/.../boards/*.conf files. This way it has to be done for every sample that would use display and an input device. And on this architecture is will be always LVGL and CONFIG_LVGL_POINTER_KSCAN, there is nothing else that could be used with it.

@jfischer-phytec-iot

I still do not agree to add new options to samples/.../boards/*.conf files

Actually the real problem here is that the basic LVGL sample has been reused to act as touchscreen sample, the best solution in this case is to split both samples and put KSCAN in the prj.conf.

And on this architecture is will be always LVGL and CONFIG_LVGL_POINTER_KSCAN, there is nothing else that could be used with it.

I think native_posix should enable as least as possible features, e.g. if I would like to test LVGL without touchscreen support I don't want to be forced to disable KSCAN in my project config files.

This sample is to simple to have two version, I suggest to move CONFIG_KSCAN=y to prj_kscan.conf

boards/posix/native_posix/Kconfig.defconfig

drivers/kscan/kscan_sdl.c

addressed

aescolar

+1 Thanks. I see no issue with this, but I leave the +2s for @vanwinkeljan or others more involved in the display area

pavlohamov · 2020-02-12T18:46:41Z

rebased on master

pavlohamov · 2020-02-18T20:23:28Z

@franciscomunoz @albertofloyd @scottwcpg any comments?

aescolar · 2020-02-19T07:36:03Z

@pavlohamov Note that the merge window is closed now until the 2.2 release. So by default this PR will be merged when it reopens again

franciscomunoz · 2020-02-28T06:18:35Z

@pavlohamov This API was intended for laptop keyboards. I see you are doing a mouse.

https://docs.zephyrproject.org/latest/reference/peripherals/kscan.html

This PR doesn't play very well with the intend of the documentation. But I don't have the last word.

pavlohamov · 2020-02-28T06:39:37Z

@pavlohamov This API was intended for laptop keyboards. I see you are doing a mouse.

https://docs.zephyrproject.org/latest/reference/peripherals/kscan.html

This PR doesn't play very well with the intend of the documentation. But I don't have the last word.

Thank you for noticing. I was referencing to #22055
Unfortunate there no "touch" API right now

MaureenHelm · 2020-03-10T15:16:08Z

@pavlohamov Note that the merge window is closed now until the 2.2 release. So by default this PR will be merged when it reopens again

The merge window is back open. Will you please rebase to retrigger CI checks?

Introduces a new SDL mouse driver for the keyboard scan (kscan) interface. Driver is implemented as SDL event filter Signed-off-by: Pavlo Hamov <pavlo_hamov@jabil.com>

Add support of SDL mouse events as input for the LVGL platforms: native_posix(_64) Signed-off-by: Pavlo Hamov <pasha.gamov@gmail.com>

pavlohamov · 2020-03-11T07:51:09Z

@pavlohamov Note that the merge window is closed now until the 2.2 release. So by default this PR will be merged when it reopens again

The merge window is back open. Will you please rebase to retrigger CI checks?

Thank you for letting me know. Done

pavlohamov requested review from albertofloyd, franciscomunoz, galak, scottwcpg and vanwinkeljan as code owners February 3, 2020 14:16

zephyrbot added area: Devicetree area: native port Host native arch port (native_sim) area: Samples Samples labels Feb 3, 2020

pavlohamov force-pushed the posix_input branch from b2a5447 to 3bc4ad4 Compare February 3, 2020 14:28

pavlohamov changed the title ~~Posix input~~ LVGL: Add Posix input Feb 3, 2020

nashif changed the title ~~LVGL: Add Posix input~~ LVGL: Add native_posix input driver Feb 3, 2020

vanwinkeljan requested changes Feb 10, 2020

View reviewed changes

drivers/kscan/Kconfig.sdl Outdated Show resolved Hide resolved

drivers/kscan/Kconfig.sdl Outdated Show resolved Hide resolved

pavlohamov force-pushed the posix_input branch from 3bc4ad4 to ea2ef2a Compare February 11, 2020 14:10

vanwinkeljan approved these changes Feb 11, 2020

View reviewed changes

vanwinkeljan requested review from aescolar and MaureenHelm February 11, 2020 17:31

jfischer-no requested changes Feb 11, 2020

View reviewed changes

pavlohamov force-pushed the posix_input branch from ea2ef2a to 5a1e6c0 Compare February 11, 2020 20:58

zephyrbot added the area: Boards label Feb 11, 2020

pavlohamov force-pushed the posix_input branch from 5a1e6c0 to a662903 Compare February 11, 2020 21:00

aescolar previously requested changes Feb 12, 2020

View reviewed changes

boards/posix/native_posix/Kconfig.defconfig Outdated Show resolved Hide resolved

boards/posix/native_posix/Kconfig.defconfig Outdated Show resolved Hide resolved

vanwinkeljan requested changes Feb 12, 2020

View reviewed changes

drivers/kscan/kscan_sdl.c Outdated Show resolved Hide resolved

pavlohamov force-pushed the posix_input branch from a662903 to 47a722a Compare February 12, 2020 11:03

pavlohamov force-pushed the posix_input branch from 47a722a to 07bcc11 Compare February 12, 2020 11:25

aescolar approved these changes Feb 12, 2020

View reviewed changes

vanwinkeljan approved these changes Feb 12, 2020

View reviewed changes

pavlohamov force-pushed the posix_input branch from 07bcc11 to 7873cf7 Compare February 12, 2020 18:46

jfischer-no approved these changes Feb 12, 2020

View reviewed changes

MaureenHelm approved these changes Feb 13, 2020

View reviewed changes

Pavlo Hamov and others added 2 commits March 11, 2020 09:48

drivers: kscan: Introduce SDL mouse driver

b2e5440

Introduces a new SDL mouse driver for the keyboard scan (kscan) interface. Driver is implemented as SDL event filter Signed-off-by: Pavlo Hamov <pavlo_hamov@jabil.com>

samples: display: lvgl use posix input, remove defaults

69e032d

Add support of SDL mouse events as input for the LVGL platforms: native_posix(_64) Signed-off-by: Pavlo Hamov <pasha.gamov@gmail.com>

pavlohamov force-pushed the posix_input branch from 7873cf7 to 69e032d Compare March 11, 2020 07:50

pavlohamov requested a review from daor-oti as a code owner March 11, 2020 07:50

MaureenHelm merged commit 44b4371 into zephyrproject-rtos:master Mar 11, 2020

pavlohamov deleted the posix_input branch February 17, 2021 21:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

LVGL: Add native_posix input driver #22426

LVGL: Add native_posix input driver #22426

pavlohamov commented Feb 3, 2020 •

edited

Loading

zephyrbot commented Feb 3, 2020 •

edited

Loading

vanwinkeljan left a comment

pavlohamov commented Feb 11, 2020 •

edited

Loading

jfischer-no Feb 11, 2020

aescolar Feb 11, 2020

jfischer-no Feb 11, 2020

pavlohamov Feb 11, 2020 •

edited

Loading

jfischer-no Feb 12, 2020 •

edited

Loading

vanwinkeljan Feb 12, 2020

jfischer-no Feb 12, 2020

aescolar left a comment

pavlohamov commented Feb 12, 2020

pavlohamov commented Feb 18, 2020

aescolar commented Feb 19, 2020 •

edited

Loading

franciscomunoz commented Feb 28, 2020

pavlohamov commented Feb 28, 2020

MaureenHelm commented Mar 10, 2020

pavlohamov commented Mar 11, 2020

LVGL: Add native_posix input driver #22426

LVGL: Add native_posix input driver #22426

Conversation

pavlohamov commented Feb 3, 2020 • edited Loading

zephyrbot commented Feb 3, 2020 • edited Loading

vanwinkeljan left a comment

Choose a reason for hiding this comment

pavlohamov commented Feb 11, 2020 • edited Loading

jfischer-no Feb 11, 2020

Choose a reason for hiding this comment

aescolar Feb 11, 2020

Choose a reason for hiding this comment

jfischer-no Feb 11, 2020

Choose a reason for hiding this comment

pavlohamov Feb 11, 2020 • edited Loading

Choose a reason for hiding this comment

jfischer-no Feb 12, 2020 • edited Loading

Choose a reason for hiding this comment

vanwinkeljan Feb 12, 2020

Choose a reason for hiding this comment

jfischer-no Feb 12, 2020

Choose a reason for hiding this comment

aescolar left a comment

Choose a reason for hiding this comment

pavlohamov commented Feb 12, 2020

pavlohamov commented Feb 18, 2020

aescolar commented Feb 19, 2020 • edited Loading

franciscomunoz commented Feb 28, 2020

pavlohamov commented Feb 28, 2020

MaureenHelm commented Mar 10, 2020

pavlohamov commented Mar 11, 2020

pavlohamov commented Feb 3, 2020 •

edited

Loading

zephyrbot commented Feb 3, 2020 •

edited

Loading

pavlohamov commented Feb 11, 2020 •

edited

Loading

pavlohamov Feb 11, 2020 •

edited

Loading

jfischer-no Feb 12, 2020 •

edited

Loading

aescolar commented Feb 19, 2020 •

edited

Loading