demo: lvgl: Add lvgl sample to draw touch events on the screen #67508

MrMarteng · 2024-01-12T07:04:26Z

This is a small lvgl touch demo application featuring functionality to "draw" on the the screen.
This can be useful to test touch input functionality during board setup.

faxe1008

Mostly small things, thanks for separating this out 👍

samples/modules/lvgl/touch_draw/prj.conf

modules/lvgl/input/lvgl_pointer_input.c

samples/modules/lvgl/touch_draw/prj.conf

samples/modules/lvgl/touch_draw/src/main.c

MrMarteng · 2024-02-21T05:41:33Z

@faxe1008 Could you please have a look at my latest modifications?

faxe1008

Morning @MrMarteng ,

I went over all conversations and marked the ones addressed by your latest push as resolved. Can you look into the remaining ones? Thank you :)

MrMarteng · 2024-02-21T16:40:39Z

Morning @MrMarteng ,

I went over all conversations and marked the ones addressed by your latest push as resolved. Can you look into the remaining ones? Thank you :)

@faxe1008 Did you submit additional comments? I already commented on all your feedback and don't see open requests for modifications.

faxe1008 · 2024-02-22T07:16:00Z

Yeah, there are still some of them unresolved. In case this is an issue with Github somehow here is the list of them:

Nit: Include sorting order
Question: Why was this moved into the switch case?
You can use k_sleep(lv_task_handler())
To make the clearing also available on the native_sim can you add a overlay with gpio_emul?

MrMarteng · 2024-02-22T18:05:44Z

Yeah, there are still some of them unresolved. In case this is an issue with Github somehow here is the list of them:

Nit: Include sorting order Question: Why was this moved into the switch case? You can use k_sleep(lv_task_handler()) To make the clearing also available on the native_sim can you add a overlay with gpio_emul?

@faxe1008 Sorry, my bad. I was the one who missed to submit the comments ;-)
I commented on all your input

MrMarteng · 2024-03-03T09:39:40Z

Yeah, there are still some of them unresolved. In case this is an issue with Github somehow here is the list of them:
Nit: Include sorting order Question: Why was this moved into the switch case? You can use k_sleep(lv_task_handler()) To make the clearing also available on the native_sim can you add a overlay with gpio_emul?

@faxe1008 Sorry, my bad. I was the one who missed to submit the comments ;-) I commented on all your input

@faxe1008 kind reminder to review my comments

faxe1008

The one still remaining thing of my comments that was not resolved is the overlay for the native_sim. If you feel like this is not needed - fine by me.

pdgendt · 2024-03-15T11:24:50Z

@MrMarteng can you rebase on latest main and verify that it works with hwmv2?

MrMarteng · 2024-04-27T10:40:23Z

@pdgendt branch is up-to-date now.
Sorry for the late response. I was quite busy beginning of this year.

MrMarteng · 2024-05-05T14:06:47Z

@kartben @brgl @pdgendt kind reminder

faxe1008 · 2024-05-05T15:15:07Z

modules/lvgl/input/lvgl_pointer_input.c

@@ -46,15 +54,6 @@ static void lvgl_pointer_process_event(const struct device *dev, struct input_ev
 		return;
 	}

-	/* adjust coordinates */
-	if (cfg->swap_xy) {


This change was included within #70541

faxe1008 · 2024-05-05T15:16:47Z

samples/modules/lvgl/touch_draw/src/main.c

+
+#ifdef CONFIG_GPIO
+	if (gpio_is_ready_dt(&button_gpio)) {
+		int err;


Maybe move upwards below struct button_callback_context btn_cb_ctx;

Good proposal. Fixed in 4393b90

github-actions · 2024-07-05T00:29:46Z

This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time.

This is a small lvgl touch demo application featuring functionality to "draw" on the the screen. This can be useful to test touch input functionality during board setup. Signed-off-by: Martin Kiepfer <mrmarteng@teleschirm.org>

MrMarteng · 2024-07-16T05:30:45Z

@brgl @kartben PR is ready for review again

pdgendt · 2024-07-16T13:01:17Z

Zephyr currently has a feature freeze for 3.7, this will have to wait for the LTS release.

github-actions · 2024-09-15T00:35:29Z

This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time.

mmahadevan108 · 2024-09-19T21:40:36Z

@kartben , can you take a look at this PR

kartben · 2024-08-01T19:02:16Z

samples/modules/lvgl/touch_draw/boards/m5stack_core2.conf

@@ -0,0 +1,3 @@
+# SPDX-License-Identifier: Apache-2.0


make it an soc overlay (a la https://github.com/zephyrproject-rtos/zephyr/tree/main/samples/net/wifi/socs)

kartben · 2024-08-01T19:02:54Z

samples/modules/lvgl/touch_draw/boards/m5stack_stamps3.conf

@@ -0,0 +1,3 @@
+# SPDX-License-Identifier: Apache-2.0


Ditto with esp32s2 overlay

kartben · 2024-08-01T19:04:24Z

samples/modules/lvgl/touch_draw/src/main.c

+		lv_task_handler();
+		k_sleep(K_MSEC(10));


Suggested change

lv_task_handler();

k_sleep(K_MSEC(10));

k_sleep(lv_task_handler());

mmahadevan108 · 2024-09-25T16:48:40Z

@MrMarteng , could you help look at the comments from @kartben

MrMarteng force-pushed the lvgl_touch_draw_sample branch 8 times, most recently from b2b1c7d to 55b20e6 Compare January 14, 2024 12:21

MrMarteng marked this pull request as ready for review January 14, 2024 14:32

zephyrbot added area: LVGL Light and Versatile Graphics Library Support area: Samples Samples labels Jan 14, 2024

zephyrbot requested review from brgl, faxe1008, kartben, nashif and pdgendt January 14, 2024 14:32

zephyrbot assigned kartben Jan 14, 2024

faxe1008 requested changes Jan 14, 2024

View reviewed changes

kartben mentioned this pull request Jan 31, 2024

samples: modules: lvgl: add keypad and encoder demo #68358

Closed

MrMarteng force-pushed the lvgl_touch_draw_sample branch from 55b20e6 to 943d098 Compare February 9, 2024 21:07

MrMarteng requested a review from faxe1008 February 9, 2024 21:22

MrMarteng force-pushed the lvgl_touch_draw_sample branch from 943d098 to 7665fd7 Compare February 9, 2024 21:46

faxe1008 requested changes Feb 21, 2024

View reviewed changes

MrMarteng requested a review from faxe1008 February 22, 2024 20:34

faxe1008 previously approved these changes Mar 3, 2024

View reviewed changes

MrMarteng force-pushed the lvgl_touch_draw_sample branch from 7665fd7 to 702f24c Compare April 14, 2024 19:12

MrMarteng dismissed faxe1008’s stale review via ff91056 April 14, 2024 19:19

MrMarteng force-pushed the lvgl_touch_draw_sample branch from 702f24c to ff91056 Compare April 14, 2024 19:19

faxe1008 reviewed May 5, 2024

View reviewed changes

larsgk mentioned this pull request May 27, 2024

modules: lvgl: Fix coordinate handling for invert-{x,y} and swap-xy #70541

Merged

github-actions bot added the Stale label Jul 5, 2024

MrMarteng force-pushed the lvgl_touch_draw_sample branch from ff91056 to ff45b1e Compare July 15, 2024 19:56

MrMarteng force-pushed the lvgl_touch_draw_sample branch from ff45b1e to 4393b90 Compare July 15, 2024 20:00

github-actions bot removed the Stale label Jul 16, 2024

MrMarteng requested a review from faxe1008 July 16, 2024 05:30

faxe1008 approved these changes Jul 16, 2024

View reviewed changes

pdgendt added this to the v4.0.0 milestone Jul 16, 2024

kartben mentioned this pull request Aug 19, 2024

samples: drivers: added a simple touch controller sample #77227

Merged

github-actions bot added the Stale label Sep 15, 2024

pdgendt removed the Stale label Sep 15, 2024

pdgendt approved these changes Sep 15, 2024

View reviewed changes

kartben requested changes Sep 19, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

demo: lvgl: Add lvgl sample to draw touch events on the screen #67508

demo: lvgl: Add lvgl sample to draw touch events on the screen #67508

MrMarteng commented Jan 12, 2024

faxe1008 left a comment

MrMarteng commented Feb 21, 2024

faxe1008 left a comment

MrMarteng commented Feb 21, 2024 •

edited

Loading

faxe1008 commented Feb 22, 2024

MrMarteng commented Feb 22, 2024 •

edited

Loading

MrMarteng commented Mar 3, 2024

faxe1008 left a comment

pdgendt commented Mar 15, 2024

MrMarteng commented Apr 27, 2024

MrMarteng commented May 5, 2024

faxe1008 May 5, 2024

faxe1008 May 5, 2024

MrMarteng Jul 15, 2024 •

edited

Loading

github-actions bot commented Jul 5, 2024

MrMarteng commented Jul 16, 2024

pdgendt commented Jul 16, 2024

github-actions bot commented Sep 15, 2024

mmahadevan108 commented Sep 19, 2024

kartben Aug 1, 2024

kartben Aug 1, 2024

kartben Aug 1, 2024

mmahadevan108 commented Sep 25, 2024

	lv_task_handler();
	k_sleep(K_MSEC(10));
	k_sleep(lv_task_handler());

demo: lvgl: Add lvgl sample to draw touch events on the screen #67508

Are you sure you want to change the base?

demo: lvgl: Add lvgl sample to draw touch events on the screen #67508

Conversation

MrMarteng commented Jan 12, 2024

faxe1008 left a comment

Choose a reason for hiding this comment

MrMarteng commented Feb 21, 2024

faxe1008 left a comment

Choose a reason for hiding this comment

MrMarteng commented Feb 21, 2024 • edited Loading

faxe1008 commented Feb 22, 2024

MrMarteng commented Feb 22, 2024 • edited Loading

MrMarteng commented Mar 3, 2024

faxe1008 left a comment

Choose a reason for hiding this comment

pdgendt commented Mar 15, 2024

MrMarteng commented Apr 27, 2024

MrMarteng commented May 5, 2024

faxe1008 May 5, 2024

Choose a reason for hiding this comment

faxe1008 May 5, 2024

Choose a reason for hiding this comment

MrMarteng Jul 15, 2024 • edited Loading

Choose a reason for hiding this comment

github-actions bot commented Jul 5, 2024

MrMarteng commented Jul 16, 2024

pdgendt commented Jul 16, 2024

github-actions bot commented Sep 15, 2024

mmahadevan108 commented Sep 19, 2024

kartben Aug 1, 2024

Choose a reason for hiding this comment

kartben Aug 1, 2024

Choose a reason for hiding this comment

kartben Aug 1, 2024

Choose a reason for hiding this comment

mmahadevan108 commented Sep 25, 2024

MrMarteng commented Feb 21, 2024 •

edited

Loading

MrMarteng commented Feb 22, 2024 •

edited

Loading

MrMarteng Jul 15, 2024 •

edited

Loading