Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

samples: modules: lvgl: add keypad and encoder demo #68358

Closed
wants to merge 1 commit into from

Conversation

everedero
Copy link
Contributor

Adds the LVGL keypad and encoder demo to sample build.

Adds the LVGL keypad and encoder demo to sample build.

Signed-off-by: Eve Redero <eve.redero@gmail.com>
@zephyrbot zephyrbot added the area: Samples Samples label Jan 31, 2024
@kartben kartben added the area: LVGL Light and Versatile Graphics Library Support label Jan 31, 2024
@kartben
Copy link
Collaborator

kartben commented Jan 31, 2024

Nice! Didn't know about this sample :)
@faxe1008 it almost feels like we should really get the "basic" sample back to a minimal one like we used to have if demos allows folks to quickly try out more complex scenarios, inc. input, on their boards? But then there's also things like #67508 that can be quite useful ...

@faxe1008
Copy link
Collaborator

@everedero thanks for your submission, indeed this sample was missing :^). Overall looks fine to me, but I was wondering if an overlay might make sense here because this sample does not work "out of the box" with the native_sim as the sample readme would suggest. Using zephyr,native-linux-evdev could be an elegant solution for this.

@kartben agree on this. After this PR is merged pretty much all indev are covered in other samples (except the button indev one) and could be removed, making the sample more basic once again 👍

@everedero
Copy link
Contributor Author

@faxe1008 That would be nice indeed, I will try to add this.

Copy link

github-actions bot commented Apr 1, 2024

This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time.

@github-actions github-actions bot added the Stale label Apr 1, 2024
@everedero everedero closed this Apr 8, 2024
@everedero
Copy link
Contributor Author

Will be done in PR #68168

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: LVGL Light and Versatile Graphics Library Support area: Samples Samples Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants